🌱 vcsim: implement cluster proxy to allow more e2e tests to be compatible to vcsim #3072

chrischdi · 2024-06-25T12:00:49Z

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

chrischdi · 2024-06-25T12:00:53Z

/test help

k8s-ci-robot · 2024-06-25T12:00:55Z

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
/test pull-cluster-api-provider-vsphere-test-main
/test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-vsphere-apidiff-main
/test pull-cluster-api-provider-vsphere-janitor-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-vsphere-apidiff-main
pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
pull-cluster-api-provider-vsphere-test-main
pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chrischdi · 2024-06-25T12:01:07Z

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

chrischdi · 2024-06-26T06:31:19Z

/retest

chrischdi · 2024-06-26T06:31:25Z

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

chrischdi · 2024-06-27T11:30:14Z

/retest

k8s-ci-robot · 2024-06-28T23:32:57Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chrischdi · 2024-07-04T10:01:54Z

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

chrischdi · 2024-07-04T10:03:34Z

Enabled vcsim on following tests to see where it fails.

Disclamer: might not make sense for all of these tests to enable it.

Cluster creation with anti affined nodes [vcsim]
When upgrading a workload cluster using ClusterClass [vcsim] [supervisor] [ClusterClass]
When testing ClusterClass changes [vcsim] [supervisor] [ClusterClass]
When testing clusterctl upgrades using ClusterClass (CAPV 1.10=>current, CAPI 1.7=>1.7) [vcsim] [ClusterClass]
When testing clusterctl upgrades using ClusterClass (CAPV 1.9=>current, CAPI 1.6=>1.7) [vcsim] [ClusterClass]
ClusterClass Creation using Cluster API quick-start test and IPAM Provider [vcsim] [ClusterClass]
Cluster creation with storage policy [vcsim]
Label nodes with ESXi host info [vcsim]

chrischdi · 2024-07-04T10:33:41Z

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

chrischdi · 2024-07-04T14:41:23Z

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

fabriziopandini · 2024-07-04T14:59:09Z

test/e2e/e2e_suite_test.go

@@ -272,7 +272,11 @@ var _ = SynchronizedBeforeSuite(func() []byte {
 			Finder: vsphereFinder,
 		}))
 	}
-	bootstrapClusterProxy = framework.NewClusterProxy("bootstrap", kubeconfigPath, initScheme(), clusterProxyOptions...)
+	if testTarget == VCSimTestTarget {
+		bootstrapClusterProxy = vspherevcsim.NewClusterProxy("bootstrap", kubeconfigPath, initScheme(), clusterProxyOptions...)


I will add a comment about why we need this

chrischdi · 2024-07-04T15:22:36Z

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

chrischdi · 2024-07-04T16:36:10Z

/retest flake

k8s-ci-robot · 2024-07-04T16:36:13Z

@chrischdi: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
/test pull-cluster-api-provider-vsphere-test-main
/test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-vsphere-apidiff-main
/test pull-cluster-api-provider-vsphere-janitor-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-vsphere-apidiff-main
pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
pull-cluster-api-provider-vsphere-test-main
pull-cluster-api-provider-vsphere-verify-main

In response to this:

/retest flake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chrischdi · 2024-07-04T16:36:27Z

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

chrischdi · 2024-07-04T16:40:18Z

/test pull-cluster-api-provider-vsphere-test-main

flake

chrischdi · 2024-07-04T17:10:29Z

Bumped to CAPI main and rebased

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

sbueringer

Nice one!

sbueringer · 2024-07-04T17:34:38Z

test/framework/vcsim/cluster_proxy.go

+
+	// Create a dialer which proxies through the kube-apiserver to the vcsim pod's port where the simulated kube-apiserver
+	// is running.
+	proxyDialer, err := inmemoryproxy.NewDialer(inmemoryproxy.Proxy{


Really elegant that we can reuse this here. Nice!

chrischdi · 2024-07-05T06:15:44Z

Forgot to run make generate-modules

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

sbueringer · 2024-07-05T08:18:30Z

/lgtm
/approve

k8s-ci-robot · 2024-07-05T08:18:35Z

LGTM label has been added.

Git tree hash: 060160103faca54ec86dee6f12a1c45edf0c4163

k8s-ci-robot · 2024-07-05T08:18:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from MaxRink and vrabbi June 25, 2024 12:00

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 25, 2024

chrischdi force-pushed the pr-vcsim-cluster-upgrades branch from a576bc7 to c68832b Compare June 26, 2024 06:19

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2024

chrischdi force-pushed the pr-vcsim-cluster-upgrades branch from c68832b to 0ff9e6f Compare July 4, 2024 10:01

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 4, 2024

chrischdi force-pushed the pr-vcsim-cluster-upgrades branch from 0ff9e6f to 3718351 Compare July 4, 2024 10:33

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2024

chrischdi force-pushed the pr-vcsim-cluster-upgrades branch from 3718351 to 22e8a98 Compare July 4, 2024 14:34

chrischdi mentioned this pull request Jul 4, 2024

🌱 test: add restConfigModifier Option to clusterProxy kubernetes-sigs/cluster-api#10832

Merged

chrischdi changed the title ~~🌱 [DNR][WIP] vcsim: implement cluster proxy to allow more e2e tests to be compatible to vcsim~~ 🌱 [WIP] vcsim: implement cluster proxy to allow more e2e tests to be compatible to vcsim Jul 4, 2024

chrischdi force-pushed the pr-vcsim-cluster-upgrades branch from 22e8a98 to e63c227 Compare July 4, 2024 14:41

chrischdi added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 4, 2024

fabriziopandini reviewed Jul 4, 2024

View reviewed changes

chrischdi force-pushed the pr-vcsim-cluster-upgrades branch from bce6d36 to 3675277 Compare July 4, 2024 17:10

chrischdi changed the title ~~🌱 [WIP] vcsim: implement cluster proxy to allow more e2e tests to be compatible to vcsim~~ 🌱 vcsim: implement cluster proxy to allow more e2e tests to be compatible to vcsim Jul 4, 2024

sbueringer reviewed Jul 4, 2024

View reviewed changes

chrischdi added 3 commits July 5, 2024 08:15

bump CAPI

6f3dc9c

vcsim: implement proxy to allow upgrade cases

c9153b2

Enable vcsim where possible

67bfc48

chrischdi force-pushed the pr-vcsim-cluster-upgrades branch from 3675277 to 67bfc48 Compare July 5, 2024 06:15

sbueringer mentioned this pull request Jul 5, 2024

Improve e2e testing #2995

Closed

16 tasks

k8s-ci-robot assigned sbueringer Jul 5, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024

k8s-ci-robot merged commit d7c9c8b into kubernetes-sigs:main Jul 5, 2024
17 checks passed

k8s-ci-robot added this to the v1.11 milestone Jul 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 vcsim: implement cluster proxy to allow more e2e tests to be compatible to vcsim #3072

🌱 vcsim: implement cluster proxy to allow more e2e tests to be compatible to vcsim #3072

chrischdi commented Jun 25, 2024

chrischdi commented Jun 25, 2024

k8s-ci-robot commented Jun 25, 2024

chrischdi commented Jun 25, 2024

chrischdi commented Jun 26, 2024

chrischdi commented Jun 26, 2024

chrischdi commented Jun 27, 2024

k8s-ci-robot commented Jun 28, 2024

chrischdi commented Jul 4, 2024

chrischdi commented Jul 4, 2024 •

edited

Loading

chrischdi commented Jul 4, 2024

chrischdi commented Jul 4, 2024

fabriziopandini Jul 4, 2024

chrischdi commented Jul 4, 2024

chrischdi commented Jul 4, 2024

k8s-ci-robot commented Jul 4, 2024

chrischdi commented Jul 4, 2024

chrischdi commented Jul 4, 2024

chrischdi commented Jul 4, 2024

sbueringer left a comment

sbueringer Jul 4, 2024

chrischdi commented Jul 5, 2024

sbueringer commented Jul 5, 2024

k8s-ci-robot commented Jul 5, 2024

k8s-ci-robot commented Jul 5, 2024

🌱 vcsim: implement cluster proxy to allow more e2e tests to be compatible to vcsim #3072

🌱 vcsim: implement cluster proxy to allow more e2e tests to be compatible to vcsim #3072

Conversation

chrischdi commented Jun 25, 2024

chrischdi commented Jun 25, 2024

k8s-ci-robot commented Jun 25, 2024

chrischdi commented Jun 25, 2024

chrischdi commented Jun 26, 2024

chrischdi commented Jun 26, 2024

chrischdi commented Jun 27, 2024

k8s-ci-robot commented Jun 28, 2024

chrischdi commented Jul 4, 2024

chrischdi commented Jul 4, 2024 • edited Loading

chrischdi commented Jul 4, 2024

chrischdi commented Jul 4, 2024

fabriziopandini Jul 4, 2024

Choose a reason for hiding this comment

chrischdi commented Jul 4, 2024

chrischdi commented Jul 4, 2024

k8s-ci-robot commented Jul 4, 2024

chrischdi commented Jul 4, 2024

chrischdi commented Jul 4, 2024

chrischdi commented Jul 4, 2024

sbueringer left a comment

Choose a reason for hiding this comment

sbueringer Jul 4, 2024

Choose a reason for hiding this comment

chrischdi commented Jul 5, 2024

sbueringer commented Jul 5, 2024

k8s-ci-robot commented Jul 5, 2024

k8s-ci-robot commented Jul 5, 2024

chrischdi commented Jul 4, 2024 •

edited

Loading