Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 test: fix wording in vsphere.yaml comment, always use bootstrapClusterProxy to get vCenterSimulator #3097

Merged
merged 2 commits into from
Jul 5, 2024
Merged

🌱 test: fix wording in vsphere.yaml comment, always use bootstrapClusterProxy to get vCenterSimulator #3097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1eff3f
test: fix wording in vsphere.yaml comment
chrischdi Jul 5, 2024
830d008
revert usage of clusterproxy
chrischdi Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/config/vsphere.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ variables:
EXP_NODE_ANTI_AFFINITY: "true"
CAPI_DIAGNOSTICS_ADDRESS: ":8080"
CAPI_INSECURE_DIAGNOSTICS: "true"
# Required to be set to install capv-supervisor <= v1.10, but getting created.
# Required to be set to install capv-supervisor <= v1.10.
SERVICE_ACCOUNTS_CM_NAMESPACE: "capv-system"
SERVICE_ACCOUNTS_CM_NAME: "service-accounts-cm"

Expand Down
2 changes: 1 addition & 1 deletion test/e2e/e2e_setup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func Setup(specName string, f func(testSpecificSettings func() testSettings), op
testSpecificIPAddressClaims, testSpecificVariables = vcsimAddressManager.ClaimIPs(ctx, vsphereip.WithIP(options.additionalIPVariableNames...))

// variables derived from the vCenterSimulator
vCenterSimulator, err := vspherevcsim.Get(ctx, c)
vCenterSimulator, err := vspherevcsim.Get(ctx, bootstrapClusterProxy.GetClient())
Expect(err).ToNot(HaveOccurred(), "Failed to get VCenterSimulator")

Byf("Creating EnvVar %s", klog.KRef(metav1.NamespaceDefault, specName))
Expand Down
Loading