Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 [release-1.9] test: add env var to allow setting CPI to insecure and use it in CI #3116

Merged
merged 1 commit into from
Jul 24, 2024
Merged

🌱 [release-1.9] test: add env var to allow setting CPI to insecure and use it in CI #3116

merged 1 commit into from
Jul 24, 2024

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

We want to switch to SHA256 thumbprints in CI. The used CPI version on this branch do only support SHA1. Because of that we set them to insecure.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Jul 23, 2024
@chrischdi
Copy link
Member Author

/test help

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2024
@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-release-1-9
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-29-1-30-release-1-9
  • /test pull-cluster-api-provider-vsphere-test-integration-release-1-9
  • /test pull-cluster-api-provider-vsphere-test-release-1-9
  • /test pull-cluster-api-provider-vsphere-verify-release-1-9

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-release-1-9
  • /test pull-cluster-api-provider-vsphere-janitor-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-release-1-9
  • pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-release-1-9
  • pull-cluster-api-provider-vsphere-test-integration-release-1-9
  • pull-cluster-api-provider-vsphere-test-release-1-9
  • pull-cluster-api-provider-vsphere-verify-release-1-9

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2024
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-govmomi-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-29-1-30-release-1-9

@chrischdi chrischdi changed the title [WIP][release-1.9] test: add env var to allow setting CPI to insecure and use it in CI [WIP][release-1.9] 🌱 test: add env var to allow setting CPI to insecure and use it in CI Jul 23, 2024
@chrischdi chrischdi changed the title [WIP][release-1.9] 🌱 test: add env var to allow setting CPI to insecure and use it in CI 🌱 [WIP][release-1.9] test: add env var to allow setting CPI to insecure and use it in CI Jul 23, 2024
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-release-1-9

1 similar comment
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-release-1-9

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2024
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-release-1-9

2 similar comments
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-release-1-9

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-release-1-9

@chrischdi chrischdi force-pushed the pr-e2e-cpi-insecure branch 2 times, most recently from 90bcae1 to 4d84219 Compare July 24, 2024 10:32
chrischdi
chrischdi commented Jul 24, 2024
View reviewed changes
packaging/flavorgen/flavors/util/helpers.go
@@ -79,7 +79,6 @@ var (
regexVar(env.VSphereServerVar),
regexVar(env.VSphereTemplateVar),
regexVar(env.VSphereStoragePolicyVar),
// TODO: Why was thumbprint not here?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it did not necessarily need the escape thing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even understand what "not here" means, do you? (as it is in l.82)

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-govmomi-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-29-1-30-release-1-9

@chrischdi chrischdi changed the title 🌱 [WIP][release-1.9] test: add env var to allow setting CPI to insecure and use it in CI 🌱 [release-1.9] test: add env var to allow setting CPI to insecure and use it in CI Jul 24, 2024
fabriziopandini
fabriziopandini reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 26e946573744d50e85cb7a7bcf0b3491ce32233c

@sbueringer
Copy link
Member

Thx!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@sbueringer
Copy link
Member

sbueringer commented Jul 24, 2024 •
edited
Loading

/hold

not sure if you want to run more tests

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-govmomi-release-1-9
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-29-1-30-release-1-9

Let's run them again

@chrischdi
Copy link
Member Author

And then let tide do its thing

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1bca988 into kubernetes-sigs:release-1.9 Jul 24, 2024
20 checks passed
@chrischdi chrischdi mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@gab-satchi gab-satchi Awaiting requested review from gab-satchi

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @k8s-ci-robot @sbueringer @fabriziopandini