-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Skip kube-vip-prepare for 1.31+ k8s since CAPI won't depend on super-admin.conf #3168
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…admin.conf Signed-off-by: Lubron Zhan <[email protected]>
e1ef4d7
to
f30c22b
Compare
I manually modified the file. Looks like I shouldn't
|
Signed-off-by: Lubron Zhan <[email protected]>
Looks like this does not work, there seems to still be some dependency on the loadbalancer IP in this case:
|
More details: |
cc @sbueringer |
Dumb, question, how does it work before in 1.28. Kube-vip also use the admin.conf generated by kubeadm, if kubeadm applies the rbac after, then kube-vip can't bootstrap either I assume in old k8s version? |
v1.29 introduced the |
IC. so kubelet is able to talk to api through local ip, but not kubeadm. Kubeadm still talks to api through control plane ip. Is there use case that kubeadm init will be run not on the control plane node? Should it also support this mode to talk to api through localhost?
|
@neolit123 what do you think |
What this PR does / why we need it:
Skip kube-vip-prepare for 1.31+ k8s since CAPI won't depend on super-admin.conf
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes ##2596