-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 [release-1.10] csi: use images from new location #3202
🌱 [release-1.10] csi: use images from new location #3202
Conversation
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-release-1-10 |
/lgtm /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: bfc857df5c6bd50d1d7d5674c9ffb34b3d5fcbd0
|
53f4d42
to
27b7298
Compare
/hold for testing at team-cluster-api#25 |
- kind: ConfigMap | ||
name: vsphere-csi-node | ||
- kind: ConfigMap | ||
name: vsphere-csi-controller | ||
- kind: Secret | ||
name: cloud-controller-manager | ||
- kind: Secret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to drop CSI instead of replacing the image. Is this because there are no new images available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This drops csi for the manifests of tests involving v1.8. these manifests still use v2.1 csi which we don't have images for... also we don't depend on csi during these tests.
27b7298
to
736512b
Compare
@chrischdi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
LGTM label has been added. Git tree hash: d320064db0dbd4c2fdd88733ffc06ffbbd95baea
|
/hold cancel |
ec192ef
into
kubernetes-sigs:release-1.10
What this PR does / why we need it:
Manual cherry-pick of #3200
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #