Skip to content

Commit

Permalink
Merge pull request #11306 from chrischdi/cp-pr-consider-all-cp-machin…
Browse files Browse the repository at this point in the history
…es-for-status-version

🐛 [release-1.8] kcp: consider all machines for setting .status.version
  • Loading branch information
k8s-ci-robot authored Oct 21, 2024
2 parents 8757a95 + 3e9ec72 commit 4f37883
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions controlplane/kubeadm/internal/controllers/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ func (r *KubeadmControlPlaneReconciler) updateStatus(ctx context.Context, contro
return nil
}

machinesWithHealthyAPIServer := controlPlane.Machines.Filter(collections.HealthyAPIServer())
lowestVersion := machinesWithHealthyAPIServer.LowestVersion()
lowestVersion := controlPlane.Machines.LowestVersion()
if lowestVersion != nil {
controlPlane.KCP.Status.Version = lowestVersion
}
Expand Down

0 comments on commit 4f37883

Please sign in to comment.