Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more descriptive Message to DrainingFailedReason and DrainingReason #10056

Closed
Tracked by #10852
adilGhaffarDev opened this issue Jan 25, 2024 · 6 comments · Fixed by #11074
Closed
Tracked by #10852

Add more descriptive Message to DrainingFailedReason and DrainingReason #10056

adilGhaffarDev opened this issue Jan 25, 2024 · 6 comments · Fixed by #11074
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@adilGhaffarDev
Copy link
Contributor

adilGhaffarDev commented Jan 25, 2024

What would you like to be added (User Story)?

As a user/operator when draining I would like to have more descriptive message in the machine status.

Detailed Description

In DrainingReason we can show in the message which pod is being evicted right now we are getting this information from the callback OnPodDeletionOrEvictionStarted and similarly when draining fails we can also get the information of failed to evict pod from OnPodDeletionOrEvictionFinished.

Anything else you would like to add?

Right now we show information regarding evicted pod in the machine controller logs using OnPodDeletedOrEvicted callback. Showing more info in the status using other callbacks(OnPodDeletionOrEvictionStarted and OnPodDeletionOrEvictionFinished) will help end user more, checking logs is bit cumbersome.

Label(s) to be applied

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini
Copy link
Member

Generally, +1 if we get that info back from the drain library and this won't be too noisy
Less also links the previous issue #7887 and if possible explains the difference with the current one

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 31, 2024
@adilGhaffarDev
Copy link
Contributor Author

Generally, +1 if we get that info back from the drain library

We are getting this information now. It was changed in this PR: kubernetes/kubernetes#117502

this won't be too noisy

I need to check this.

Less also links the previous issue #7887 and if possible explains the difference with the current one

This PR was asking for too much, as discussed there I agree with Fabrizio we don't need this much information regarding pods on machine status. Just more descriptive Message on the reason should be enough.

@adilGhaffarDev
Copy link
Contributor Author

/assign

@fabriziopandini
Copy link
Member

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Apr 11, 2024
@sbueringer
Copy link
Member

sbueringer commented Aug 30, 2024

Just to keep an overview over the implementation + docs etc.:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
4 participants