-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more descriptive Message to DrainingFailedReason and DrainingReason #10056
Comments
This issue is currently awaiting triage. If CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Generally, +1 if we get that info back from the drain library and this won't be too noisy /triage accepted |
We are getting this information now. It was changed in this PR: kubernetes/kubernetes#117502
I need to check this.
This PR was asking for too much, as discussed there I agree with Fabrizio we don't need this much information regarding pods on machine status. Just more descriptive Message on the reason should be enough. |
/assign |
/priority backlog |
Just to keep an overview over the implementation + docs etc.: |
What would you like to be added (User Story)?
As a user/operator when draining I would like to have more descriptive message in the machine status.
Detailed Description
In DrainingReason we can show in the message which pod is being evicted right now we are getting this information from the callback OnPodDeletionOrEvictionStarted and similarly when draining fails we can also get the information of failed to evict pod from OnPodDeletionOrEvictionFinished.
Anything else you would like to add?
Right now we show information regarding evicted pod in the machine controller logs using OnPodDeletedOrEvicted callback. Showing more info in the status using other callbacks(OnPodDeletionOrEvictionStarted and OnPodDeletionOrEvictionFinished) will help end user more, checking logs is bit cumbersome.
Label(s) to be applied
/kind feature
The text was updated successfully, but these errors were encountered: