📖 Add Node drain documentation #11121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
Please ignore the first commit, I'll rebase once the underlying PR merges. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/assign @fabriziopandini @chrischdi @enxebre |
sbueringer
changed the title
sbueringer
added
area/machine
docs/book/src/tasks/automated-machine-management/machine_deletions.md
Outdated
Show resolved
Hide resolved
sbueringer
force-pushed
the
pr-improve-node-drain-doc
branch
from
b59fdbc
to
ab25023
Compare
k8s-ci-robot
added
size/L
sbueringer
force-pushed
the
pr-improve-node-drain-doc
branch
from
ab25023
to
06fb511
Compare
enxebre
reviewed
Sep 2, 2024
docs/book/src/tasks/automated-machine-management/machine_deletions.md
Outdated
Show resolved
Hide resolved
enxebre
reviewed
Sep 2, 2024
| 9. Machine controller deletes the `BootstrapConfig` object (e.g. `KubeadmConfig`) of the machine and waits until it is gone | ||
| 10. Machine controller deletes the Node object in the workload cluster | ||
| * Node deletion will be retried until either the Node object is gone or `Machine.spec.nodeDeletionTimeout` is expired (`0` means no timeout, but the field defaults to 10s) | ||
|
|
There was a problem hiding this comment.
maybe mention node deletion (orthogonally) and volume detach are usually performed by the ccm
There was a problem hiding this comment.
Added the first point.
I think for the second: it's CSI and I have the following note above: "* Typically the volumes are getting detached by CSI after the corresponding Pods have been evicted during drain"
Is that fine as is?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ef4e5461d7fab209d6ad3c6daa22d7ff4ec2bb94
|
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-improve-node-drain-doc
branch
from
06fb511
to
1858a75
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8c3c62aaaa0f0e2b8149eddf8d6807441b698b1a
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds documentation for Machine deletions and Node drains.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #10056