Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and document bring-your-own-cert use cases for KCP #9568

Closed
killianmuldoon opened this issue Oct 18, 2023 · 2 comments · Fixed by #9585 · May be fixed by #10681
Closed

Test and document bring-your-own-cert use cases for KCP #9568

killianmuldoon opened this issue Oct 18, 2023 · 2 comments · Fixed by #9585 · May be fixed by #10681
Assignees
@lentzi90
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@killianmuldoon
Copy link
Contributor

Cluster API should clearly document and test bring-your-own-cert use cases for KCP. A change in v1.5 requiring generated certs to have the cluster.x-k8s.io/cluster-name=${CLUSTER_NAME} label is not fully documented.

#9080 added documentation for the kubeconfig - but it should be updated to make clear that this also applies to all other secrets generated for KCP. This change should be backported to release-1.5.

We should also add a test - an integration test if possible showing the failing and non-failing cases - so we can prevent regressions in this behaviour in future.

h/t @lentzi90 for reporting this. Reference slack thread..
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 18, 2023
@killianmuldoon
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 18, 2023
@lentzi90
Copy link
Contributor

/assign

@lentzi90 lentzi90 mentioned this issue Oct 20, 2023
Merged
@dalees dalees mentioned this issue Oct 27, 2023
Merged
@lentzi90 lentzi90 mentioned this issue May 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lentzi90 lentzi90

Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
3 participants
@lentzi90 @k8s-ci-robot @killianmuldoon