🌱 Test BYO certificates #10681
🌱 Test BYO certificates #10681
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
Finally got around to add the CA verfification now. |
| @@ -408,6 +409,9 @@ func fakeCASecret(namespace, name string, caData []byte) *corev1.Secret { | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: name, | |||
| Namespace: namespace, | |||
| Labels: map[string]string{ | |||
There was a problem hiding this comment.
I think this is not necessary anymore as soon as we merge #10633
There was a problem hiding this comment.
Let's definitely revert (after #10633 merges it should work without). This secret should not require the cluster-name label (also the secret should not correspond to any cluster)
There was a problem hiding this comment.
Makes sense! I will wait for it to merge, then rebase and remove this. 🙂
There was a problem hiding this comment.
Thanks!
@adilGhaffarDev or @Sunnatillo does anyone of you want to take this over? It may be some time until I can get back to it since I'm on parental leave 😇
There was a problem hiding this comment.
I can address the comments and push the changes.
There was a problem hiding this comment.
pushed the changes, please check.
This adds an integration test for BYO CA certificate. It is practically a copy of TestReconcileInitializeControlPlane but with a custom CA and a check to verify that the generated kubeconfig is really using this CA. Signed-off-by: Lennart Jern <[email protected]>
Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
adilGhaffarDev
force-pushed
the
lentzi90/test-byo-certs
branch
from
3c9cc4a
to
652b346
Compare
|
/retest |
|
@lentzi90: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I think this also requires changes to another test, see: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/10681/pull-cluster-api-test-main/1812731035935313920 |
What this PR does / why we need it:
This adds an integration test for BYO CA certificate. It is practically a copy of TestReconcileInitializeControlPlane but with a custom CA and a check to verify that the generated kubeconfig is really using this CA.
To make the test environment behave similar to the real world, it now also has a cache that picks up objects based on labels. For this reason it was also necessary to add labels in a few places.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #9568 (it was closed already when we added the docs)
/area testing