-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update docs for beta ClusterResourceSet #10289
Conversation
/area clusterresourceset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a general agreement to promote CRS to beta as well? Do we have an issue covering what's needed here like we do for MachinePools - i.e. #9005?
AFAICT ClusterResourceSet has been beta already for quite a while: cluster-api/feature/feature.go Lines 37 to 41 in af5f2c9
cluster-api/feature/feature.go Lines 71 to 75 in af5f2c9
So I thought this PR was just catching up with reality by marking it beta in the "experimental features" doc where it was still labeled alpha, and removing all the places where we say "don't forget to turn on this experimental feature." But I may be mistaken. |
I'm really not sure - but this is something that should probably have a tracking issue and be brought up at the community meeting IMO - I'm not sure if a decision was made to turn this on by default in this way but it would be good to make sure. |
/hold
I added this as a discussion topic for the March 27th CAPI community meeting. |
/hold cancel At today's office hours meeting, consensus was that CRS has been beta and that it was an oversight that |
docs/book/src/tasks/experimental-features/experimental-features.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/experimental-features.md
Outdated
Show resolved
Hide resolved
Updated to include great review comments from @neolit123. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
pls unhold if no additional review is pending.
LGTM label has been added. Git tree hash: 03f338a8c18b267488151656ab6311ca2cf28164
|
Thank you very much for taking care of this! /hold cancel I would not backport this as I think we shouldn't go from disabled per default to enabled per default in a patch release (for folks using our manager.yaml / components.yaml / clusterctl) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, neolit123, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Updates the documentation (and two manifests) to reflect the status of the ClusterResourceSet experimental feature as Beta and
true
by default.When creating a PR to promote the MachinePools experimental feature to Beta /
true
, it seemed there was similar cleanup that should be done to CRS.Which issue(s) this PR fixes:
N/A, but see also #10141
/area documentation