Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Implement controller paused condition for core CAPI resources #10364

Closed
wants to merge 8 commits into from
Closed

WIP: Implement controller paused condition for core CAPI resources #10364

wants to merge 8 commits into from

Conversation

theobarberbany
Copy link
Contributor

@theobarberbany theobarberbany commented Apr 2, 2024 •
edited
Loading

What this PR does / why we need it:

This PR Adds the Paused condition, and tests to all of the core CAPI resources.

Fixes #10130

/area area/provider/core

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @theobarberbany!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @theobarberbany. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2024
@fabriziopandini
Copy link
Member

@theobarberbany PTAL comments on the original issue

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2024
@theobarberbany theobarberbany force-pushed the pausing-machine-controller branch 2 times, most recently from f040e82 to e369071 Compare April 9, 2024 18:19
@theobarberbany theobarberbany mentioned this pull request Apr 9, 2024
Open
@theobarberbany
Copy link
Contributor Author

/area area/provider/core

@k8s-ci-robot
Copy link
Contributor

@theobarberbany: The label(s) area/area/provider/core cannot be applied, because the repository doesn't have them.

In response to this:

/area area/provider/core

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theobarberbany
Copy link
Contributor Author

/area provider/core

@k8s-ci-robot k8s-ci-robot added area/provider/core Issues or PRs related to the core provider and removed do-not-merge/needs-area PR is missing an area label labels Apr 26, 2024
@theobarberbany theobarberbany changed the title WIP: Machine controller paused condition WIP: Implement controller paused condition for core CAPI resources Apr 26, 2024
@theobarberbany theobarberbany force-pushed the pausing-machine-controller branch 3 times, most recently from 4544633 to 588774b Compare April 29, 2024 16:52
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 30, 2024
@theobarberbany theobarberbany force-pushed the pausing-machine-controller branch 2 times, most recently from 1975743 to 660227d Compare May 1, 2024 12:59
@theobarberbany theobarberbany force-pushed the pausing-machine-controller branch 3 times, most recently from 3624ef3 to 3b20a92 Compare May 8, 2024 13:36
@theobarberbany
Copy link
Contributor Author

Waiting on: #10550 in order to update the condition with new polarity.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2024
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 4, 2024
@k8s-ci-robot
Copy link
Contributor

@theobarberbany: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-test-main c4dbfce link true /test pull-cluster-api-test-main
pull-cluster-api-e2e-blocking-main c4dbfce link true /test pull-cluster-api-e2e-blocking-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@theobarberbany
API: Adds PausedCondition and related reasons
c2ad80f 
This change updates the types to add a new PausedCondition.

It also adds two reasons: ResourcePausedReason, and
ResourceNotPausedReason

This is to enable controllers to report when a resource is paused. This
allows an administrator to work with confidence on a paused object.
@theobarberbany
Implement paused condition for machine controller
e6d2f0e 
This change updates the machine controller to set the paused condition
based on if the cluster or machine resource is paused.
@theobarberbany
Implement paused condition for cluster controller
043427e 
This change updates the cluster controller to set the paused condition
based on if the cluster is paused.
@theobarberbany
Implement paused condition for machine set controller
e5d40e9 
This change updates the machine set controller to set the paused condition
based on if the cluster or machine set resource is paused.
@theobarberbany
Implement paused condition for machine healthcheck controller
b71da57 
This change updates the machine health check controller to set the paused condition
based on if the cluster or machine health check is paused.
@theobarberbany
Implement paused condition for machine deployment controller
f695d4b 
This change updates the machine deployment controller to set the paused condition
based on if the cluster or machine deployment has the paused annotations.

If the machine deployment is paused a different reason is selected:
MachineDeploymentPausedReason
@theobarberbany
Implements paused condition for kubeadm kcp
49fd6b4
@theobarberbany
Fix linting issues
dff78de
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2024
@sbueringer
Copy link
Member

@theobarberbany Is this still needed / can we close the PR? I think we implemented Paused conditions on all types via our work on #11105

@fabriziopandini
Copy link
Member

I'm +1 to close, I would prefer to block any work on v1beta1 conditions at this point

@sbueringer
Copy link
Member

sbueringer commented Nov 14, 2024 •
edited
Loading

/close

based on comments above. Let us know if there is anything missing in the v1bet2a implementation of the Paused condition

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closed this PR.

In response to this:

/close

based on comments above

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees
No one assigned
Labels
area/provider/core Issues or PRs related to the core provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent reporting of paused resources
5 participants
@theobarberbany @k8s-ci-robot @fabriziopandini @sbueringer @k8s-triage-robot