Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update InfraCluster provider contract to account for the paused condition #10519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theobarberbany
Copy link

@theobarberbany theobarberbany commented Apr 25, 2024

What this PR does / why we need it:
This change updates the infra cluster provider contract to account for a new paused
condition.

Relates #10130

/area documentation

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @theobarberbany. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theobarberbany
Copy link
Author

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Apr 26, 2024
@theobarberbany theobarberbany force-pushed the pause-condition-update-contract branch from 285b232 to 2ff8fbd Compare April 26, 2024 11:59
@theobarberbany theobarberbany changed the title WIP: Update provider contract to account for the paused condition Update provider contract to account for the paused condition Apr 26, 2024
@theobarberbany theobarberbany marked this pull request as ready for review April 26, 2024 12:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024
@sbueringer sbueringer changed the title Update provider contract to account for the paused condition 📖 Update provider contract to account for the paused condition Apr 29, 2024
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@theobarberbany theobarberbany force-pushed the pause-condition-update-contract branch from 2ff8fbd to 24a20d0 Compare July 8, 2024 11:02
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrischdi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2024
@theobarberbany theobarberbany force-pushed the pause-condition-update-contract branch 2 times, most recently from 09bfcdb to 7207fac Compare July 8, 2024 13:11
@theobarberbany theobarberbany force-pushed the pause-condition-update-contract branch 2 times, most recently from 6cb0da9 to 3e9e664 Compare July 12, 2024 10:03
@JoelSpeed
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3e7800d827ef15b2487f3577d3597fbaddee929

@theobarberbany
Copy link
Author

Bumping this for a review cc @sbueringer :)

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL #10897 when I'm defining the transition from CAPI custom conditions to K8s conditions (which includes also paused).
Based on the first round of positive feedback, this transition is going to happen in the CAPI 1.9 timeframe, so we should make a call if to implement this or defer.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 25, 2024
@theobarberbany theobarberbany force-pushed the pause-condition-update-contract branch 2 times, most recently from 5be71d8 to 965cb82 Compare September 25, 2024 17:59
@fabriziopandini
Copy link
Member

@theobarberbany things are moving fast in the CAPI world!

FYI, https://github.com/fabriziopandini/cluster-api/blob/main/docs/proposals/20240916-improve-status-in-CAPI-resources.md recently merged, introducing a paused conditions in all CAPI resources.

Also as a side effect, there is a major refactor of docs in progress on main WRT to provider contract pages (I also gave an update yesterday at the office hours). Work is tracked in #11105 (a few PR are still missing, but I hope to complete this work by end of next week)

It would be great if contract changes in this PR can build on top of it 😅

@theobarberbany
Copy link
Author

Hey @fabriziopandini,

That's great! I was about to ask, as the Infra Cluster contract looks significantly different to the others!

I'll try and build off of that, as it seems the others will follow it's style (e.g https://github.com/kubernetes-sigs/cluster-api/pull/11223/files) How does that sound? :D

Also is there anything else in #11105 I can do to help?

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2024
@theobarberbany theobarberbany changed the title 📖 Update provider contract to account for the paused condition 📖 Update InfraCluster provider contract to account for the paused condition Sep 26, 2024
@theobarberbany
Copy link
Author

@fabriziopandini I've updated this PR to add the paused condition to the InfraCluster provider contract. Can you let me know if these changes look reasonable? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants