-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update InfraCluster provider contract to account for the paused condition #10519
base: main
Are you sure you want to change the base?
📖 Update InfraCluster provider contract to account for the paused condition #10519
Conversation
Hi @theobarberbany. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area documentation |
285b232
to
2ff8fbd
Compare
docs/book/src/developer/architecture/controllers/control-plane.md
Outdated
Show resolved
Hide resolved
/ok-to-test |
docs/book/src/developer/architecture/controllers/control-plane.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/architecture/controllers/control-plane.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/architecture/controllers/control-plane.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/architecture/controllers/control-plane.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/architecture/controllers/control-plane.md
Outdated
Show resolved
Hide resolved
2ff8fbd
to
24a20d0
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
09bfcdb
to
7207fac
Compare
6cb0da9
to
3e9e664
Compare
/lgtm |
LGTM label has been added. Git tree hash: c3e7800d827ef15b2487f3577d3597fbaddee929
|
Bumping this for a review cc @sbueringer :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL #10897 when I'm defining the transition from CAPI custom conditions to K8s conditions (which includes also paused).
Based on the first round of positive feedback, this transition is going to happen in the CAPI 1.9 timeframe, so we should make a call if to implement this or defer.
docs/book/src/developer/architecture/controllers/control-plane.md
Outdated
Show resolved
Hide resolved
docs/book/src/developer/architecture/controllers/control-plane.md
Outdated
Show resolved
Hide resolved
3e9e664
to
bf3376a
Compare
New changes are detected. LGTM label has been removed. |
5be71d8
to
965cb82
Compare
@theobarberbany things are moving fast in the CAPI world! FYI, https://github.com/fabriziopandini/cluster-api/blob/main/docs/proposals/20240916-improve-status-in-CAPI-resources.md recently merged, introducing a paused conditions in all CAPI resources. Also as a side effect, there is a major refactor of docs in progress on main WRT to provider contract pages (I also gave an update yesterday at the office hours). Work is tracked in #11105 (a few PR are still missing, but I hope to complete this work by end of next week) It would be great if contract changes in this PR can build on top of it 😅 |
Hey @fabriziopandini, That's great! I was about to ask, as the Infra Cluster contract looks significantly different to the others! I'll try and build off of that, as it seems the others will follow it's style (e.g https://github.com/kubernetes-sigs/cluster-api/pull/11223/files) How does that sound? :D Also is there anything else in #11105 I can do to help? |
965cb82
to
b4e6936
Compare
@fabriziopandini I've updated this PR to add the paused condition to the |
b4e6936
to
adfa182
Compare
What this PR does / why we need it:
This change updates the infra cluster provider contract to account for a new paused
condition.
Relates #10130
/area documentation