Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add v1.9 release team members to timeline doc #11097

Merged
merged 1 commit into from
Aug 29, 2024
Merged

🌱 Add v1.9 release team members to timeline doc #11097

merged 1 commit into from
Aug 29, 2024

Conversation

Sunnatillo
Copy link
Contributor

@Sunnatillo Sunnatillo commented Aug 26, 2024 •
edited
Loading

What this PR does / why we need it:

This PR adds v1.9 release team members to release timeline doc

Edit: Part of #11092
/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Sunnatillo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2024
@Sunnatillo Sunnatillo changed the title 🌱 Add v1.9 release team members 🌱 Add v1.9 release team members to timeline doc Aug 26, 2024
@sbueringer
Copy link
Member

Please review release-team internally and then let me know when you need an approve to merge

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 26, 2024
hackeramitkumar
hackeramitkumar approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@hackeramitkumar hackeramitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fabriziopandini
Copy link
Member

Thanks everyone for stepping up 🙇 🤟
Happy to approve when we got +1 from all the appointed release team members

@fabriziopandini fabriziopandini mentioned this pull request Aug 27, 2024
Merged
@cahillsf
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a83af31a2dd9170df83c2afb46bcd0f8928a8baa

@tasdikrahman
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

@tasdikrahman: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chandankumar4
chandankumar4 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@chandankumar4 chandankumar4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SD-13
Copy link
Contributor

SD-13 commented Aug 28, 2024

lgtm

1 similar comment
@vishalanarase
Copy link
Member

vishalanarase commented Aug 28, 2024 •
edited
Loading

lgtm

@pravarag
Copy link
Contributor

lgtm

@varshasuryawanshi
Copy link

lgtm..

@tormath1
Copy link

/lgtm

@serngawy
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@serngawy: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Sunnatillo
Copy link
Contributor Author

Thanks everyone for stepping up 🙇 🤟 Happy to approve when we got +1 from all the appointed release team members

We can merge this PR now.

@tasdikrahman tasdikrahman mentioned this pull request Aug 28, 2024
Closed
9 tasks
@Sunnatillo
Copy link
Contributor Author

Please review release-team internally and then let me know when you need an approve to merge

/ok-to-test

we can merge this now

@chrischdi
Copy link
Member

/approve

Thanks everyone!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit ff8d0f8 into kubernetes-sigs:main Aug 29, 2024
34 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Aug 29, 2024
@Sunnatillo Sunnatillo deleted the update-RT-members/sunnat branch August 29, 2024 12:54
@Sunnatillo Sunnatillo mentioned this pull request Sep 16, 2024
Open
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackeramitkumar hackeramitkumar hackeramitkumar approved these changes

@chandankumar4 chandankumar4 chandankumar4 approved these changes

@pravarag pravarag Awaiting requested review from pravarag

Assignees

@tormath1 tormath1

@cahillsf cahillsf

@vishalanarase vishalanarase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.