Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add NamingStrategy to KubeadmControlPlane #11123

Merged
merged 1 commit into from
Oct 28, 2024
Merged

🌱 Add NamingStrategy to KubeadmControlPlane #11123

merged 1 commit into from
Oct 28, 2024

Conversation

adilGhaffarDev
Copy link
Contributor

@adilGhaffarDev adilGhaffarDev commented Aug 31, 2024 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes part of #10577

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 31, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2024
@adilGhaffarDev
Copy link
Contributor Author

right now it only has API changes, and the remaining work is in progress, I opened a draft PR so I can get some early inputs.
cc @sbueringer

sbueringer
sbueringer reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some changes. Let me know what you think

controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_types.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_types.go Outdated Show resolved Hide resolved
@adilGhaffarDev adilGhaffarDev force-pushed the kcp-naming-issue-fix/adil branch 3 times, most recently from 0b403b1 to 9aa9eb9 Compare September 3, 2024 14:09
@adilGhaffarDev adilGhaffarDev marked this pull request as ready for review September 3, 2024 14:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2024
@sbueringer sbueringer added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Sep 3, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Sep 3, 2024
@sbueringer
Copy link
Member

lgtm for the API from my side (+/- the godoc nit)

Before I start to review the implementation, @fabriziopandini @chrischdi @mdbooth @lentzi90 Are we fine with the API and does it cover your use cases?

@mdbooth
Copy link
Contributor

mdbooth commented Sep 3, 2024

lgtm for the API from my side (+/- the godoc nit)

Before I start to review the implementation, @fabriziopandini @chrischdi @mdbooth @lentzi90 Are we fine with the API and does it cover your use cases?

@adilGhaffarDev is representing the interests of @lentzi90 while he's away. From my POV, I'm happy if @adilGhaffarDev thinks it covers the use case.

@adilGhaffarDev
Copy link
Contributor Author

Before I start to review the implementation, @fabriziopandini @chrischdi @mdbooth @lentzi90 Are we fine with the API and does it cover your use cases?

@lentzi90 flag was also for machineset and that is also going to be removed after 1.9, can I add same namingStrategy in MchineDeployments too in this same PR?

@adilGhaffarDev
Copy link
Contributor Author

@lentzi90 flag was also for machineset and that is also going to be removed after 1.9, can I add same namingStrategy in MchineDeployments too in this same PR?

I will open separate PR for MDs, as discussed here: #10577 (comment) , @sbueringer please review this one. Also, fuzzing tests are failing in v1alpha APIs, Do you have any idea why they are failing?

@sbueringer
Copy link
Member

@sbueringer please review this one.

I would like to get reviews from other maintainers on the API first. It's not only my call.

@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

/hold
I'll give other folks a few days time to also take another look, otherwise happy to merge

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 99d51f95cf193c78c44efc5fd94f9a757c9cabb8

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
chrischdi
chrischdi reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2024
@sbueringer
Copy link
Member

@adilGhaffarDev Can you rebase? I'll merge afterwards

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2024
@fabriziopandini
Copy link
Member

Thanks for driving this effort @adilGhaffarDev
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 82f83b511e399fb4d142abcc9773e9b43bef2d14

@adilGhaffarDev
Copy link
Contributor Author

/test pull-cluster-api-test-main

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6c04105 into kubernetes-sigs:main Oct 28, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase Awaiting requested review from richardcase

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@neolit123 neolit123 Awaiting requested review from neolit123

@vincepri vincepri Awaiting requested review from vincepri

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@chrischdi chrischdi Awaiting requested review from chrischdi

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@neolit123 neolit123

@chrischdi chrischdi

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
9 participants
@adilGhaffarDev @k8s-ci-robot @sbueringer @mdbooth @fabriziopandini @neolit123 @chrischdi @vincepri @JoelSpeed