🌱 clusterctl: add nutanix ipam & runtime extensions providers

[jimmidyson]

• 🌱 clusterctl: add nutanix ipam provider
• 🌱 clusterctl: add nutanix runtime extensions provider

[jimmidyson]

/area clusterctl

[jimmidyson]

/label tide/merge-method-squash

[jimmidyson]

@elmiko @JoelSpeed if you have time for review 🙏 should be pretty quick and easy hopefully.

[chrischdi]

Suggested change

	NutanixIPAMProviderName = "nutanix"
	NutanixIPAMProviderName = "nutanix-cloud-native-nutanix"

To follow the conventions at https://main.cluster-api.sigs.k8s.io/clusterctl/provider-contract.html#adding-a-provider-to-clusterctl

[jimmidyson]

We already have an infra provider simply called nutanix at https://github.com/kubernetes-sigs/cluster-api/blob/main/cmd/clusterctl/client/config/providers_client.go#L55 and it would be great if we could use the same name for these other provider types for consistency 🙏

[sbueringer]

Good point. Maybe it's fine if a GitHub org already "claimed" the name via another provider

[chrischdi]

Would make sense. Fine for me if we have an agreement :-)

[sbueringer]

@fabriziopandini @vincepri WDYT?

[fabriziopandini]

I think we can allow this because https://github.com/nutanix is owned by the same org that owns https://github.com/nutanix-cloud-native.

Do you mind updating https://cluster-api.sigs.k8s.io/clusterctl/provider-contract.html#providers-github-org-prefix with something like

In case the entity proposing the new providers owns different github organizations, it is also possible to Provider's GitHub org prefix (in this case it is up to this entity to avoid or address conflicts).

[jimmidyson]

I'm not sure we need to update any docs. Can't we just agree as we (Nutanix) already claimed the nutanix provider name for infra provider as mentioned above?

[jimmidyson]

I've added some docs as requested. Please review when you get a chance 🙏

[sbueringer]

I'm fine with allowing to use simply "nutanix" given that the same org already owns the "nutanix" infra provider.
@fabriziopandini Do you agree?

@jimmidyson Is this the only thing blocking this PR (apart from rebase + the nit above)?

[jimmidyson]

@sbueringer Yes this is now ready to go! Tested locally and all working perfectly!

[fabriziopandini]

I'm fine with allowing to use simply "nutanix" given that the same org already owns the "nutanix" infra provider.
@fabriziopandini Do you agree?

commented above

[jimmidyson]

@sbueringer @fabriziopandini Ping 🙏 Would love to get this merged.

[sbueringer]

Thx!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 21addfc95ae91d8a92e0405ff0a90ba65c1553cf

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

Feel free to cherry-pick into release-1.8 if you want (might require a manual cherry-pick)

[jimmidyson]

/cherrypick release-1.8

[k8s-infra-cherrypick-robot]

@jimmidyson: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@jimmidyson: #11135 failed to apply on top of branch "release-1.8":

Applying: seedling: clusterctl: add nutanix ipam provider
Using index info to reconstruct a base tree...
M	cmd/clusterctl/client/config/providers_client.go
M	cmd/clusterctl/client/config_test.go
M	cmd/clusterctl/cmd/config_repositories_test.go
A	docs/book/src/developer/providers/contracts/clusterctl.md
M	docs/book/src/reference/glossary.md
M	docs/book/src/reference/providers.md
Falling back to patching base and 3-way merge...
Auto-merging docs/book/src/reference/providers.md
Auto-merging docs/book/src/reference/glossary.md
Auto-merging docs/book/src/clusterctl/provider-contract.md
Auto-merging cmd/clusterctl/cmd/config_repositories_test.go
CONFLICT (content): Merge conflict in cmd/clusterctl/cmd/config_repositories_test.go
Auto-merging cmd/clusterctl/client/config_test.go
Auto-merging cmd/clusterctl/client/config/providers_client.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 seedling: clusterctl: add nutanix ipam provider

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jimmidyson]

Manual backport in #11414