-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 condition: fix godoc for MachineNodeHealthyCondition #11178
🌱 condition: fix godoc for MachineNodeHealthyCondition #11178
Conversation
I think this PR should be merged in any case. Our implementation simply doesn't check I have absolutely no clue if we should check the /lgtm |
LGTM label has been added. Git tree hash: c3fa39d964d40ffebe1346ecb28dbcf06d9b1603
|
Wild guess: maybe not necessary because its part of Ready |
I tried to look it up, the comment was added in: But the condition is only mentioned on the comment. |
/assign @fabriziopandini |
/lgtm Added a note about NodeNetworkUnavailable in #11105 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
We do not check
NodeNetworkUnavailable
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Follow-up of #11145 (comment)