🌱 Deprecate ClusterCacheTracker #11312
Conversation
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
| @@ -121,9 +121,6 @@ func (r *KubeadmControlPlaneReconciler) SetupWithManager(ctx context.Context, mg | |||
| r.ssaCache = ssa.NewCache() | |||
|
|
|||
| if r.managementCluster == nil { | |||
| if r.ClusterCache == nil { | |||
There was a problem hiding this comment.
Just a minor cleanup, this check is never used because we would already panic above now.
I have a follow-up to introduce proper input validation for all SetupWithManager funcs
| @@ -32,6 +32,8 @@ import ( | |||
|
|
|||
| // ClusterCacheReconciler is responsible for stopping remote cluster caches when | |||
| // the cluster for the remote cache is being deleted. | |||
| // | |||
| // Deprecated: This will be removed in Cluster API v1.10, use clustercache.ClusterCache instead. | |||
There was a problem hiding this comment.
I think it makes sense to give folks one release time to migrate away (ClusterCacheTracker would be removed with the v1.10 (April 2025) release).
Folks can always just copy the old ClusterCacheTracker if they want to continue to use it.
There was a problem hiding this comment.
works for me, should we change the PR type to make this surface in the release notes?
There was a problem hiding this comment.
To what do you want to change it?
(Just adding the deprecation itself is not a breaking change)
There was a problem hiding this comment.
Added a note here: #11092 (comment)
|
/assign @vincepri @fabriziopandini @chrischdi |
sbueringer
added
the
area/clustercachetracker
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9a38d4c9d1a81b823d1833d87e35e43d21350f68
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11272