Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Refine v1beta2 condition messages #11404

Merged
merged 1 commit into from
Nov 13, 2024
Merged

🌱 Refine v1beta2 condition messages #11404

merged 1 commit into from
Nov 13, 2024

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Nov 11, 2024 •
edited by sbueringer
Loading

What this PR does / why we need it:
Make condition messages more consistent

/area provider/core

Part of #11105

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/provider/core Issues or PRs related to the core provider labels Nov 11, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 11, 2024
@fabriziopandini fabriziopandini changed the title [WIP] 🌱 Refine v1beta2 condition messages 🌱 Refine v1beta2 condition messages Nov 12, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2024
sbueringer
sbueringer reviewed Nov 12, 2024
View reviewed changes
util/conditions/v1beta2/aggregate_test.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/aggregate_test.go Show resolved Hide resolved
util/conditions/v1beta2/summary.go Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions.go Show resolved Hide resolved
internal/controllers/machine/drain/drain.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_status.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_status.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_status_test.go Outdated Show resolved Hide resolved
internal/controllers/machineset/machineset_controller_status_test.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

sbueringer
sbueringer reviewed Nov 12, 2024
View reviewed changes
controlplane/kubeadm/internal/controllers/controller.go Outdated Show resolved Hide resolved
internal/controllers/machine/drain/drain.go Outdated Show resolved Hide resolved
internal/controllers/machine/drain/drain.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/mirror.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Feel free to squash directly

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member

Thx. Really huge improvements! :)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1a2129c4dc660972640d8d98becb25042703dadc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6d32337 into kubernetes-sigs:main Nov 13, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Nov 13, 2024
@fabriziopandini fabriziopandini deleted the refine-v1beta2-condition-messages branch November 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/core Issues or PRs related to the core provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @sbueringer @k8s-ci-robot