-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Contribute experimental cluster-api-state-metrics #6570
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
378df5c
to
6d508c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits.
Many thanks for the contribution :-)
For everyone joining the party here: This PR contains the contribution from the mercedes-benz folks. #6458 outlines the follow-up steps like e.g. the implementation of metrics missing currently but proposed in the proposal, tilt integration, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes for the replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more nit but ok for me that we do that on a follow-up PR :-)
I think we are nearly ready to squash + remove WIP :-) |
e8d3233
to
b7f2739
Compare
Signed-off-by: Tobias Giese <[email protected]> Co-authored-by: Christian Schlotter <[email protected]>
b7f2739
to
747ef52
Compare
/retitle ✨ contribute experimental cluster-api-state-metrics |
/retitle ✨ Contribute experimental cluster-api-state-metrics |
/hold |
@tobiasgiese: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks again for the intent to contribute this 👍 . Because kubernetes/kube-state-metrics#1777 got merged, we will move forward using the Custom Resource Configuration. The code here was still helpful because it provided some first example metrics and to push the topic 🎉 /close |
@chrischdi: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Tobias Giese [email protected]
Co-authored-by: Christian Schlotter [email protected]
What this PR does / why we need it:
This PR contributes the Cluster-API State Metrics exporter to the Cluster-API core repository.
As this is an experimental feature -- as discussed in the design proposal cluster-api-state-metrics -- we will store the code in
exp/
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #6458
Tobias Giese [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum