Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Contribute experimental cluster-api-state-metrics #6570

Closed

Conversation

tobiasgiese
Copy link
Member

@tobiasgiese tobiasgiese commented May 30, 2022

Signed-off-by: Tobias Giese [email protected]
Co-authored-by: Christian Schlotter [email protected]

What this PR does / why we need it:

This PR contributes the Cluster-API State Metrics exporter to the Cluster-API core repository.
As this is an experimental feature -- as discussed in the design proposal cluster-api-state-metrics -- we will store the code in exp/.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #6458

Tobias Giese [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fabriziopandini after the PR has been reviewed.
You can assign the PR to them by writing /assign @fabriziopandini in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 30, 2022
@tobiasgiese tobiasgiese force-pushed the exp/casm-introduce branch 3 times, most recently from 378df5c to 6d508c6 Compare May 30, 2022 13:49
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits.

Many thanks for the contribution :-)

For everyone joining the party here: This PR contains the contribution from the mercedes-benz folks. #6458 outlines the follow-up steps like e.g. the implementation of metrics missing currently but proposed in the proposal, tilt integration, etc.

exp/state-metrics/config/default/kustomization.yaml Outdated Show resolved Hide resolved
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes for the replace

exp/state-metrics/Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more nit but ok for me that we do that on a follow-up PR :-)

Makefile Show resolved Hide resolved
@chrischdi
Copy link
Member

I think we are nearly ready to squash + remove WIP :-)

Signed-off-by: Tobias Giese <[email protected]>
Co-authored-by: Christian Schlotter <[email protected]>
@tobiasgiese tobiasgiese changed the title [WIP] ✨ exp: contribute cluster-api-state-metrics ✨ exp: contribute cluster-api-state-metrics May 31, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2022
@chrischdi
Copy link
Member

/retitle ✨ contribute experimental cluster-api-state-metrics

@k8s-ci-robot k8s-ci-robot changed the title ✨ exp: contribute cluster-api-state-metrics ✨ contribute experimental cluster-api-state-metrics May 31, 2022
@chrischdi
Copy link
Member

/retitle ✨ Contribute experimental cluster-api-state-metrics

@k8s-ci-robot k8s-ci-robot changed the title ✨ contribute experimental cluster-api-state-metrics ✨ Contribute experimental cluster-api-state-metrics Jun 1, 2022
@sbueringer
Copy link
Member

/hold
let's try: #6458 (comment)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 3, 2022
@k8s-ci-robot
Copy link
Contributor

@tobiasgiese: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member

chrischdi commented Aug 19, 2022

Thanks again for the intent to contribute this 👍 . Because kubernetes/kube-state-metrics#1777 got merged, we will move forward using the Custom Resource Configuration.

The code here was still helpful because it provided some first example metrics and to push the topic 🎉

/close

@k8s-ci-robot
Copy link
Contributor

@chrischdi: Closed this PR.

In response to this:

Thanks again for the intent to contribute this 👍 . Because kubernetes/kube-state-metrics#1777 got merged, we will move forward using the Custom Resource Configuration.

The code here was still helpful because it provided some first example metrics 🎉

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants