📖 Sync cluster-api-state-metrics proposal to match implementation state. #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
9 tasks
sbueringer
reviewed
Sep 12, 2022
sbueringer
reviewed
Sep 13, 2022
|
lgtm pending squash |
This also removes the `_labels` metric references. There are kube-state-metrics specific flags regarding these metric which won't affect custom resource configuration (allow/deny-list). Exposing all metrics would lead increase the cardinality without being worth it. Use-case specific configuration should be added by the user if required.
chrischdi
force-pushed
the
pr-fix-casm-proposal
branch
from
2474963
to
91ed330
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm it would be great if @tobiasgiese (co-author on this proposal) could take a quick look, otherwise, I will approve in a couple of days |
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Syncs the cluster-api-state-metrics proposal to match implementation state.
Implementation was mostly done in #7095
This also removes the
_labelsmetric references. There are kube-state-metrics specific flags regarding these metric which won't affect custom resource configuration (allow/deny-list). Exposing all metrics would lead increase the cardinality without being worth it. Use-case specific configuration should be added by the user if required.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #6458