-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add CRS re-reconcile to ownerReference test #9296
🌱 Add CRS re-reconcile to ownerReference test #9296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area e2e-testing
/cherry-pick release-1.5 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon <[email protected]>
1b1cf0d
to
2c44bf1
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: e3337ab53a3bb44205fcd761265e0079e6fa74d3
|
@killianmuldoon: new pull request created: #9301 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add a function to force reconciliation of the ClusterResourceSet to the the ownerReference test.
This ensures these ownerRefs are always reconciled before asserting the full graph. This hasn't been seen as an issue in core CAPI, but was causing flaky behaviour when using these utils in CAPV ref: kubernetes-sigs/cluster-api-provider-vsphere#2209