-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature routegroup #1444
Feature routegroup #1444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, PTAL 🙂
@njuettner I fixed all your comments |
f40460b
to
e70c5c0
Compare
@njuettner @linki I rebased and forced push to have a clean history. I also fixed a bug in the http.Client usage, I had before, which I found while testing in a dev cluster. |
add documentation for kube-ingress-aws-controller and RouteGroup Signed-off-by: Sandor Szücs <[email protected]>
e70c5c0
to
116856f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
||
token, err := ioutil.ReadFile(cli.tokenFile) | ||
if err != nil { | ||
log.Errorf("Failed to read token from file (%s): %v", cli.tokenFile, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we return
here? This would retain the previous token if we failed to read the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes makes sense
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linki, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR implements #1403
It does not use client-go, nor informer. It's just a simple poll on
Endpoints()
.I added also a tutorial for kube-ingress-aws-controller, that was missing and added there a RouteGroup part.
The
routegroup
source has the same feature set as theingress
source and needs to be enabled by--source=skipper-routegroup
.In case you are interested, you can find a more detailed explanation of the RouteGroup CRD.