feat: Node Repair implementation #1793
Open
+457
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: engedaam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
Pull Request Test Coverage Report for Build 11874233136Details
💛 - Coveralls |
engedaam
changed the title
engedaam
force-pushed
the
node-repair-implementation
branch
from
4635c80
to
192984f
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
engedaam
force-pushed
the
node-repair-implementation
branch
2 times, most recently
from
2338123
to
8cefba7
Compare
engedaam
force-pushed
the
node-repair-implementation
branch
9 times, most recently
from
c8bed26
to
390c056
Compare
engedaam
force-pushed
the
node-repair-implementation
branch
from
390c056
to
562ed1f
Compare
k8s-ci-robot
added
do-not-merge/invalid-commit-message
engedaam
force-pushed
the
node-repair-implementation
branch
from
03e110a
to
cf6220e
Compare
engedaam
force-pushed
the
node-repair-implementation
branch
8 times, most recently
from
b20e724
to
8397b07
Compare
engedaam
force-pushed
the
node-repair-implementation
branch
9 times, most recently
from
445cb11
to
be92bc0
Compare
engedaam
force-pushed
the
node-repair-implementation
branch
2 times, most recently
from
ffb2103
to
f0186f9
Compare
engedaam
force-pushed
the
node-repair-implementation
branch
from
f0186f9
to
cab6157
Compare
| ctx = injection.WithControllerName(ctx, "node.health") | ||
| ctx = log.IntoContext(ctx, log.FromContext(ctx).WithValues("Node", klog.KRef(node.Namespace, node.Name))) | ||
|
|
||
| // Validate that the node is owned by us and is not being deleted |
There was a problem hiding this comment.
Suggested change
| // Validate that the node is owned by us and is not being deleted | |
| // Validate that the node is owned by us |
nit: we aren't doing the deletion check anymore
| cpPolicyFound := cloudprovider.RepairPolicy{} | ||
| // Find a node with a condition that matches one of the unhealthy conditions defined by the cloud provider | ||
| // If there are multiple unhealthy status condition we will requeue based on the condition closest to its terminationDuration | ||
| for _, policy := range c.cloudProvider.RepairPolicies() { |
There was a problem hiding this comment.
nit: This feels like it should be a separate function given it feels like it has "arguments" and it's pretty self-contained
| return reconcile.Result{}, client.IgnoreNotFound(err) | ||
| } | ||
| if err := c.kubeClient.Delete(ctx, nodeClaim); err != nil { | ||
| return reconcile.Result{}, err |
There was a problem hiding this comment.
This delete could have a NotFound error -- consider adding a client.IgnoreNotFound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
RepairPolicythat will support node conditions that Karpenter will forcefully terminate nodes. The cloud provider policies will be unhealthy conditions a node can enter and the duration for Karpenter to react.How was this change tested?
make resubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.