feat: Supporting new topologySpread scheduling constraints #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tPolicy: Always Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: vboxuser <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: syedsadath-17 <[email protected]>
Signed-off-by: syedsadath-17 <[email protected]>
Signed-off-by: syedsadath-17 <[email protected]>
sadath-12
changed the title
|
I'd maybe consider moving this PR back in draft. From what I can tell this PR isn't ready for review yet (doesn't have all the test cases yet, doesn't completely resolves the issue that is linked to it). If we want to scope down the PR, that's fine, I'd just include detail of that in the description and make sure that we don't have "Fixes ..." in the description so that we don't close the issue until it's truly done. |
|
thank you @jonathan-innis , ill make this pr ready to merge in my upcoming commits |
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
|
Holding this pr for a while |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
github-actions
bot
added
the
lifecycle/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #430
Description
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.