Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only start the extender plugin when needed in scheduler-perf #125

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions internal/e2e/scheduler_perf/scheduler_perf_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -762,9 +762,11 @@ func runWorkload(ctx context.Context, b *testing.B, tc *testCase, w *workload) [
finalFunc, podInformer, client, dynClient := mustSetupScheduler(ctx, b, cfg, registory)
b.Cleanup(finalFunc)

// start extender
go extender.Start()
defer extender.Shutdown()
// Start extender if needed.
if cfg != nil && len(cfg.Extenders) > 0 {
go extender.Start()
defer extender.Shutdown()
}

var mu sync.Mutex
var dataItems []DataItem
Expand Down
Loading