Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle comments in list correctly #3965

Merged
merged 2 commits into from
Jun 8, 2021
Merged

handle comments in list correctly #3965

merged 2 commits into from
Jun 8, 2021

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Jun 4, 2021 •
edited
Loading

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2021
@mengqiy
Copy link
Member Author

mengqiy commented Jun 4, 2021

cc: @Shell32-Natsu @phanimarupaka @droot

@Shell32-Natsu
Copy link
Contributor

/cc @monopole

@k8s-ci-robot k8s-ci-robot requested a review from monopole June 4, 2021 20:12
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2021
@mengqiy mengqiy mentioned this pull request Jun 4, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2021
phanimarupaka
phanimarupaka approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@phanimarupaka phanimarupaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Giving sometime for others to review.

@monopole
Copy link
Contributor

monopole commented Jun 4, 2021

/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengqiy, phanimarupaka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 4, 2021
@phanimarupaka phanimarupaka removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2021
@mengqiy mengqiy mentioned this pull request Jun 4, 2021
Merged
@monopole
Copy link
Contributor

monopole commented Jun 5, 2021

#3789 is going in first, and before that we need to be sure where kubectl can land w/r to go-yaml/yaml dependence.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2021
@mengqiy
Copy link
Member Author

mengqiy commented Jun 7, 2021

I removed the changes related to go-yaml.
@monopole @Shell32-Natsu PTAL

monopole
monopole reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for not adding that new dep.

Some small nits

kyaml/comments/comments.go Outdated Show resolved Hide resolved
kyaml/kio/byteio_writer.go Outdated Show resolved Hide resolved
kyaml/kio/byteio_writer.go Outdated Show resolved Hide resolved
kyaml/yaml/serialization.go Show resolved Hide resolved
@monopole monopole removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2021
@mengqiy
Copy link
Member Author

mengqiy commented Jun 7, 2021

I rebased on top of HEAD.
The last commit is the new changes since last review.
@monopole PTAL

@mengqiy mengqiy requested review from monopole and phanimarupaka June 7, 2021 23:30
@mengqiy
Copy link
Member Author

mengqiy commented Jun 7, 2021

/assign @monopole @Shell32-Natsu

@monopole
Copy link
Contributor

monopole commented Jun 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
@monopole monopole merged commit 440026b into kubernetes-sigs:master Jun 8, 2021
@mengqiy mengqiy deleted the listcomments branch June 8, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 Awaiting requested review from natasha41575

@Shell32-Natsu Shell32-Natsu Awaiting requested review from Shell32-Natsu

@monopole monopole Awaiting requested review from monopole

@phanimarupaka phanimarupaka Awaiting requested review from phanimarupaka

Assignees

@monopole monopole

@Shell32-Natsu Shell32-Natsu

@phanimarupaka phanimarupaka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mengqiy @Shell32-Natsu @monopole @k8s-ci-robot @phanimarupaka