-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Always use forward slash in originAnnotations #5826
base: master
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
Hi @cblims. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @cblims! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cblims The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this change makes sense in unifying the filepath for Unix systems, I'm just curious on whether it would break Windows users wherein input path would be with \
, but the output would be /
which could be incompatible. (I have not much experience in using Kustomize with windows).
@koba1t @stormqueen1990 @antoooks any thoughts?
@cblims could you please also add a test case in origin_test.go
that verifies this scenario?
This change fixes originAnnotations where Kustomize on Windows generate paths with backslashes (), which conflicts when the same configuration is applied on Linux/macOS (using /).