Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not apply approved label if change requested #270

Closed
wants to merge 1 commit into from
Closed

fix: do not apply approved label if change requested #270

wants to merge 1 commit into from

Commits on Sep 5, 2024

  1. fix: do not apply approved label if change requested 

    An outstanding CHANGES_REQUESTED state prevents a PR from being
merged even if another reviewer approves the PR. This change makes it so
that the approved label cannot be added until all change requested
states have been resolved.

This prevents a scenario where tide will repeatedly try to merge a PR
and be rejected by GitHub due to the changes requested state.
    @sdowell
    sdowell committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    1bdbd87 View commit details
    Browse the repository at this point in the history