Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openstack-cinder-csi helm chart for multi cloud support #2681

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

guillaumebernard84
Copy link
Contributor

What this PR does / why we need it:

Hello, this PR modifies the openstack-cinder-csi helm chart to allow to use it with the multi cloud feature: #2551

It fixes two problems that were preventing to use the chart with multi cloud:

  1. When runing the cinder-csi-plugin with multi-region, you need to specify different extraArgs on the cinder-csi-plugin containers of the deployment and the daemonset. It wasn't possible with the current version. Now you can, like this:
nodePlugin:
  extraArgs: |-
    - --cloud-name=region-one
    - --additional-topology
    - topology.kubernetes.io/region=region-one
controllerPlugin:
  extraArgs: |-
    - --cloud-name=region-one
    - --cloud-name=region-two

You still need to create the second daemonset manually, but at least you can use the chart. If this PR is accepted, I'll work on a new one to allow the creation of the second daemonset.

  1. If you use the resizer and the snapshotter, you will need them to be able to read the secrets you defined in the storage class' annotations in order to determine which cloud to address. This was hardcoded in controllerplugin-rbac.yaml, now you can specify it like this:
snapshotter:
  extraRbac:
    - apiGroups: [""]
      resources: ["secrets"]
      verbs: ["get", "list"]
resizer:
  extraRbac:
    - apiGroups: [""]
      resources: ["secrets"]
      verbs: ["get", "list", "watch"]

I also moved the comments from controllerplugin-rbac.yaml to the values file.

I added these info to the multi-region-clouds.md documentation file.

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kayrus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot requested a review from zetaab September 30, 2024 13:07
@k8s-ci-robot
Copy link
Contributor

Hi @guillaumebernard84. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants