Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use absolute paths in tests #1063

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

We should not assume that folder and resourcePool names are unique within our test vCenter
(with Boskos we will use absolute paths anyway)

Please also see: kubernetes-sigs/cluster-api-provider-vsphere#3035

Special notes for your reviewer:

Release note:

Signed-off-by: Stefan Büringer [email protected]
@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 6, 2024
@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cloud-provider-vsphere-build
  • /test pull-cloud-provider-vsphere-coverage
  • /test pull-cloud-provider-vsphere-integration-test
  • /test pull-cloud-provider-vsphere-unit-test
  • /test pull-cloud-provider-vsphere-verify-fmt
  • /test pull-cloud-provider-vsphere-verify-lint
  • /test pull-cloud-provider-vsphere-verify-markdown
  • /test pull-cloud-provider-vsphere-verify-shell
  • /test pull-cloud-provider-vsphere-verify-staticcheck
  • /test pull-cloud-provider-vsphere-verify-vet

The following commands are available to trigger optional jobs:

  • /test pull-cloud-provider-vsphere-e2e-test
  • /test pull-cloud-provider-vsphere-e2e-test-on-latest-k8s-version

Use /test all to run the following jobs that were automatically triggered:

  • pull-cloud-provider-vsphere-coverage
  • pull-cloud-provider-vsphere-e2e-test
  • pull-cloud-provider-vsphere-e2e-test-on-latest-k8s-version

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2024
@sbueringer
Copy link
Member Author

@sbueringer
Copy link
Member Author

/test pull-cloud-provider-vsphere-e2e-test
/test pull-cloud-provider-vsphere-e2e-test-on-latest-k8s-version

Copy link
Member

@XudongLiuHarold XudongLiuHarold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

thanks @sbueringer !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, XudongLiuHarold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 68a65a5 into kubernetes:master Jun 6, 2024
9 checks passed
@sbueringer sbueringer deleted the pr-absolute-paths branch June 6, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants