Skip to content

Commit

Permalink
Fix re-adding stuff on rebase
Browse files Browse the repository at this point in the history
Signed-off-by: Ricardo Lopes <[email protected]>
  • Loading branch information
ricardoapl committed Dec 16, 2024
1 parent 942aeef commit 9781d2b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ jobs:
make BASE_IMAGE=registry.k8s.io/ingress-nginx/nginx:${TAGNGINX} clean-image build image image-chroot
make -C test/e2e-image image
cd images/custom-error-pages/rootfs && docker image build \
--build-arg=BASE_IMAGE=registry.k8s.io/ingress-nginx/nginx-1.25:${TAGNGINX} \
--build-arg=BASE_IMAGE=registry.k8s.io/ingress-nginx/nginx:${TAGNGINX} \
--build-arg GOLANG_VERSION=$(cat ../../../GOLANG_VERSION) \
--tag ingress-controller/custom-error-pages:1.0.0-dev . \
&& cd ../../..
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/zz-tmpl-k8s-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ jobs:
SKIP_INGRESS_IMAGE_CREATION: true
SKIP_E2E_IMAGE_CREATION: true
SKIP_CUSTOMERRORPAGES_IMAGE_CREATION: true
ENABLE_VALIDATIONS: ${{ inputs.variation == 'VALIDATIONS' }}
IS_CHROOT: ${{ inputs.variation == 'CHROOT' }}
run: |
kind get kubeconfig > $HOME/.kube/kind-config-kind
Expand Down
8 changes: 4 additions & 4 deletions images/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ EXTRAARGS ?= $(shell cat $(NAME)/EXTRAARGS)
export DOCKER_CLI_EXPERIMENTAL=enabled

# build with buildx
BUILDX_PLATFORMS ?= linux/amd64,linux/arm,linux/arm64,linux/s390x
OUTPUT ?=
PROGRESS = plain
PLATFORMS?=linux/amd64,linux/arm,linux/arm64
OUTPUT?=
PROGRESS=plain


precheck:
Expand All @@ -58,7 +58,7 @@ build: precheck ensure-buildx
--label=org.opencontainers.image.description="Ingress NGINX $(NAME) image" \
--build-arg BASE_IMAGE=$(BASE_IMAGE) \
--build-arg GOLANG_VERSION=$(GO_VERSION) \
--platform=${BUILDX_PLATFORMS} $(OUTPUT) \
--platform=${PLATFORMS} $(OUTPUT) \
--progress=$(PROGRESS) \
--pull $(EXTRAARGS) \
-t $(IMAGE):$(TAG) $(NAME)/rootfs
Expand Down

0 comments on commit 9781d2b

Please sign in to comment.