WIP: go port of releng/generate_tests python script

[DannyBrito]

This WIP PR, it is an attempt to do a go port of relenge/generate_test python script. At this current stage the PR aims to be as close as possible to a one-to-one port of the script. Meaning any other wrong assumptions and bugs could be present.

Issue related: #29390

I am posting this WIP branch as I encounter some things that I would like to get feedback.
I have come to the realization that marshalling and unmarshalling yaml in golang is a possible hard task, in respect to preserving. comments, anchors, alias, etc.

The other option was to use templates to produce the desired output. Which is the option, I decided to explore, as the output of the script seem to be fully generated by the script and it didn't seem like needed more that simple comments stating the file was autogenerated.

The generation test golang script works. However, while comparing results of original script and go port I noticed that the original preserves/uses anchors and alias, example. The go port does not handle these cases and will produce the entire object. Will this be a deal breaker?

Am I missing any other possible way to solve/implement this?

cc: @jeremyrickard

[k8s-ci-robot]

Welcome @DannyBrito!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @DannyBrito. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DannyBrito
Once this PR has been reviewed and has the lgtm label, please assign cici37 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• releng/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xmudrii]

/remove-lifecycle stale

[DannyBrito]

The primary blocker for creating these golang ports of python script #29390 was unmarshalling and marshalling yaml in go is painful when the yaml file has the following comments, anchors and aliases. There is not good way to preserve these directly.

At the beginning of implementing this PR porting generate_tests script. I chose to use templating as I only saw the use the case of a simple comment in output yaml auto-gen... message, that is straight forward with templating. However, after comparing full output yaml result files. I noticed the use of anchors and alias. So, if preserving these is a must. This route was not longer a good option.

Note: This implementation was aiming to directly mirror the python script, so it includes possible no longer valid assumptions, and bugs.

[Vyom-Yadav]

@DannyBrito, I don't think that not supporting anchors and aliases should be a problem. They are only there to reduce duplication. They can simply be replaced by values rather than aliases. Implementing some fancy solution or using some other yaml library isn't worth it IMO just to have anchors and aliases. Comments have been dealt with, so if this script produces logically the same output as the python one, I don't see any problem.

@xmudrii What do you think?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[xmudrii]

/remove-lifecycle rotten
I'm at the moment going to remove lifecycle label from this PR, however, we're considering completely getting rid of those tools in favor of the fork mechanism.