-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert some jobs to Ginkgo --label-filter #32648
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,7 @@ periodics: | |
kind build node-image --image=dra/node:latest . && | ||
trap 'kind export logs "${ARTIFACTS}/kind"; kind delete cluster' EXIT && | ||
kind create cluster --retain --config test/e2e/dra/kind.yaml --image dra/node:latest && | ||
KUBERNETES_PROVIDER=local KUBECONFIG=${HOME}/.kube/config GINKGO_PARALLEL_NODES=8 E2E_REPORT_DIR=${ARTIFACTS} hack/ginkgo-e2e.sh -ginkgo.focus=DynamicResourceAllocation -ginkgo.skip=\[Serial\] | ||
KUBERNETES_PROVIDER=local KUBECONFIG=${HOME}/.kube/config GINKGO_PARALLEL_NODES=8 E2E_REPORT_DIR=${ARTIFACTS} hack/ginkgo-e2e.sh -ginkgo.filter='Feature: containsAny DynamicResourceAllocation && !Serial' | ||
|
||
# docker-in-docker needs privileged mode | ||
securityContext: | ||
|
@@ -82,7 +82,7 @@ periodics: | |
- '--node-test-args=--feature-gates="DynamicResourceAllocation=true" --service-feature-gates="DynamicResourceAllocation=true" --runtime-config=resource.k8s.io/v1alpha2=true --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | ||
- --node-tests=true | ||
- --provider=gce | ||
- --test_args=--focus="\[Feature:DynamicResourceAllocation\]" --skip="\[Flaky\]" | ||
- "--test_args=--label-filter='Feature: containsAny DynamicResourceAllocation && !Flaky'" | ||
- --timeout=65m | ||
- --node-args=--image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/crio/latest/image-config-cgrpv1-serial.yaml | ||
env: | ||
|
@@ -135,7 +135,7 @@ periodics: | |
- '--node-test-args=--feature-gates="DynamicResourceAllocation=true" --service-feature-gates="DynamicResourceAllocation=true" --runtime-config=resource.k8s.io/v1alpha2=true --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | ||
- --node-tests=true | ||
- --provider=gce | ||
- --test_args=--focus="\[Feature:DynamicResourceAllocation\]" --skip="\[Flaky\]" | ||
- "--test_args=--label-filter='Feature: containsAny DynamicResourceAllocation && !Flaky'" | ||
- --timeout=65m | ||
- --node-args=--image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/crio/latest/image-config-cgrpv2-serial.yaml | ||
env: | ||
|
@@ -188,7 +188,7 @@ periodics: | |
- '--node-test-args=--feature-gates="DynamicResourceAllocation=true" --service-feature-gates="DynamicResourceAllocation=true,SchedulerQueueingHints=true" --runtime-config=resource.k8s.io/v1alpha2=true --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | ||
- --node-tests=true | ||
- --provider=gce | ||
- --test_args=--focus="\[Feature:DynamicResourceAllocation\]" --skip="\[Flaky\]" | ||
- "--test_args=--label-filter='Feature: containsAny DynamicResourceAllocation && !Flaky'" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. e2e-node tests do not preserve white space properly 😢
In this case, it's a limitation of ssh, but that is something that the e2e_node tests should be aware of. The solution for "run complex shell commands via ssh" is to invoke Will prepare a fix. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Except that this occurs so deep down that properly composing the input script has the same problems. I guess it boils down to "use double quotes" for |
||
- --timeout=65m | ||
- --node-args=--image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/crio/latest/image-config-cgrpv1-serial.yaml | ||
env: | ||
|
@@ -240,7 +240,7 @@ periodics: | |
- '--node-test-args=--feature-gates="DynamicResourceAllocation=true" --service-feature-gates="DynamicResourceAllocation=true,SchedulerQueueingHints=true" --runtime-config=resource.k8s.io/v1alpha2=true --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' | ||
- --node-tests=true | ||
- --provider=gce | ||
- --test_args=--focus="\[Feature:DynamicResourceAllocation\]" --skip="\[Flaky\]" | ||
- "--test_args=--label-filter='Feature: containsAny DynamicResourceAllocation && !Flaky'" | ||
- --timeout=65m | ||
- --node-args=--image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/crio/latest/image-config-cgrpv2-serial.yaml | ||
env: | ||
|
@@ -292,7 +292,7 @@ periodics: | |
- '--node-test-args=--feature-gates="DynamicResourceAllocation=true" --service-feature-gates="DynamicResourceAllocation=true" --runtime-config=resource.k8s.io/v1alpha2=true --container-runtime-endpoint=unix:///var/run/containerd/containerd.sock --container-runtime-process-name=/usr/local/bin/containerd --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"containerd.log\", \"journalctl\": [\"-u\", \"containerd\"]}"' | ||
- --node-tests=true | ||
- --provider=gce | ||
- --test_args=--focus="\[Feature:DynamicResourceAllocation\]" --skip="\[Flaky\]" | ||
- "--test_args=--label-filter='Feature: containsAny DynamicResourceAllocation && !Flaky'" | ||
- --timeout=65m | ||
- --node-args=--image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/dra/image-config-containerd-1.7.yaml | ||
resources: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, now that I look at this one last time after merging I am spotting a typo! 🥵
s/-ginkgo.filter/-gingko.label-filter/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#32770