Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post to announce ApplySet-based pruning in kubectl #40070

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Add blog post to announce ApplySet-based pruning in kubectl #40070

merged 1 commit into from
Apr 24, 2023

Conversation

KnVerey
Copy link
Contributor

@KnVerey KnVerey commented Mar 17, 2023

Feature blog post for KEP 3659: https://git.k8s.io/enhancements/keps/sig-cli/3659-kubectl-apply-prune.
KEP issue: kubernetes/enhancements#3659

Extracted from #39818, which I opened on Mar 6 but mistakenly put both the blog post placeholder and the docs placeholder in the same PR. Sorry! 🤦‍♀️ Thanks @sftim for setting me straight.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Mar 17, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 17, 2023
@KnVerey KnVerey mentioned this pull request Mar 17, 2023
Merged
@KnVerey
Copy link
Contributor Author

KnVerey commented Mar 17, 2023

/assign @justinsb

@harshitasao
Copy link
Contributor

@KnVerey @justinsb

Hello, Comms Lead for the 1.27 release here. This feature blog is tracked for release, the deadline for submitting the draft is on 4th of April- the sooner the better since there's still editing to be done afterwards. Any doubt, the Comms team is here to help.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2023
@KnVerey
Copy link
Contributor Author

KnVerey commented Apr 3, 2023

@justinsb I know you were working on a draft for this, but since I haven't heard from you and the deadline is tomorrow, I've pushed up some content. Please feel free to replace it with what you were working on.

@KnVerey KnVerey changed the title Placeholder: Add blog post to announce ApplySet-based pruning in kubectl Add blog post to announce ApplySet-based pruning in kubectl Apr 3, 2023
@netlify
Copy link

netlify bot commented Apr 3, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2d7cc47
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64343b7a8e421b0008a07b9a
😎 Deploy Preview https://deploy-preview-40070--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@harshitasao
Copy link
Contributor

@KnVerey @justinsb
Reminder: The feature blog ready to review deadline is tomorrow (April 4th)

@KnVerey KnVerey marked this pull request as ready for review April 4, 2023 16:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2023
sftim
sftim reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
pending assignment of publication date

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2023
sftim
sftim reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the title, the feedback in this review is recommended but optional.

content/en/blog/_posts/2023-04-11-Safer-More-Performant-Pruning-in-Kubectl-Apply.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-Safer-More-Performant-Pruning-in-Kubectl-Apply.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-Safer-More-Performant-Pruning-in-Kubectl-Apply.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-Safer-More-Performant-Pruning-in-Kubectl-Apply.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-Safer-More-Performant-Pruning-in-Kubectl-Apply.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-Safer-More-Performant-Pruning-in-Kubectl-Apply.md Outdated Show resolved Hide resolved
@justinsb
Copy link
Member

justinsb commented Apr 7, 2023

I read the blog post and it's really good - I only had nit-picks about hyphenation and I think they are more a matter of personal taste. I have a propensity-for-overuse-of-hyphens, perhaps :-)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4c81d5a71cefdb93765cd7112d70d83bd745854f

@harshitasao
Copy link
Contributor

Hello, Comms Lead for v1.27 here. The publication order and date for the Feature Blog series has been finalized and the tracking board is updated.

The publication date for this article is 09-05-2023 (May 09).

Thank you!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2023
@KnVerey
Copy link
Contributor Author

KnVerey commented Apr 10, 2023

The publication date for this article is 09-05-2023 (May 09).

Renamed the file and adjusted the metadata to reflect this

@sftim
Copy link
Contributor

sftim commented Apr 11, 2023

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 96cfc0ada9e22710bfc0f170a72a7e947b6cb77e

@sftim
Copy link
Contributor

sftim commented Apr 24, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit cc5d82c into kubernetes:main Apr 24, 2023
Zhuzhenghao pushed a commit to Zhuzhenghao/website that referenced this pull request Apr 25, 2023
@k8s-ci-robot @Zhuzhenghao
Merge pull request kubernetes#40070 from KnVerey/applyset-blog-post
5ff4d2b 
Add blog post to announce ApplySet-based pruning in kubectl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KnVerey @harshitasao @justinsb @k8s-ci-robot @sftim