Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated container garbage collection with accurate information #48001

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated container garbage collection with accurate information #48001

wants to merge 1 commit into from
+14 −6

Conversation

T-Lakshmi
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign princesso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 19, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7f6ab53
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66ec27ef0cb8ac000816af54
😎 Deploy Preview https://deploy-preview-48001--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@T-Lakshmi
Copy link
Contributor Author

/sig node
/kind documentation

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/documentation Categorizes issue or PR as related to documentation. labels Sep 19, 2024
@T-Lakshmi
Copy link
Contributor Author

Preview page

Hi @dipesh-rawat, @Princesso,
Pinging for review, PTAL!

@T-Lakshmi T-Lakshmi mentioned this pull request Sep 19, 2024
Open
@bart0sh
Copy link
Contributor

bart0sh commented Sep 19, 2024

/cc @haircommander @esotsal

haircommander
haircommander reviewed Sep 19, 2024
View reviewed changes
content/en/docs/concepts/architecture/garbage-collection.md
### Container garbage collection {#container-image-garbage-collection} (deprecated)

{{< caution >}}
Container garbage collection is deprecated infavour of `--eviction-hard` or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in favour *

haircommander
haircommander reviewed Sep 19, 2024
View reviewed changes
content/en/docs/concepts/architecture/garbage-collection.md

{{< caution >}}
Container garbage collection is deprecated infavour of `--eviction-hard` or
`--eviction-soft` and Will be removed in a future version. For more details on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will*

@haircommander
Copy link
Contributor

thanks! content wise it looks good, I just have a couple of stylistic nits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@Princesso Princesso Awaiting requested review from Princesso

@esotsal esotsal Awaiting requested review from esotsal

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. language/en Issues or PRs related to English language sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node PR Triage
Status: Needs Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear with Container garbage collection configuration
4 participants
@T-Lakshmi @k8s-ci-robot @bart0sh @haircommander