Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom popup for displaying editor schemas #2049

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

olensmar
Copy link
Member

@olensmar olensmar commented Jul 5, 2022

This PR starts a local server for hosting custom schemas requested by the editor. The server is started in a worker window - which could be expanded for further async-processing later on.

The main (only?) drawback with this approach is that the user will be prompted to allow local network connections when the server starts the first time (which it does lazily as needed - which might be never for many users...).

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

path: schemaPath,
content: JSON.stringify(resourceSchema, null, 2),
});
schemaUri = `http://localhost:51038${schemaPath}`;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

port is hardcoded - need to get the actual port from the server

@pull-request-size pull-request-size bot added size/M and removed size/L labels Jul 6, 2022
@olensmar olensmar changed the title feat: initial implementation of local server for hosting editor schemas feat: custom popup for displaying editor schemas Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant