Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set pruneDeadBranches to false when without discarder #1019

Merged
merged 1 commit into from
Nov 6, 2023
Merged

set pruneDeadBranches to false when without discarder #1019

merged 1 commit into from
Nov 6, 2023

Conversation

yudong2015
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1018

Does this PR introduce a user-facing change??

fix the bug that disable delete branchs not works

@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. labels Nov 5, 2023
@yudong2015 yudong2015 requested a review from chilianyi November 5, 2023 17:55
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2023
@yudong2015
Copy link
Collaborator Author

/cherrypick release-3.4

@ks-ci-bot
Copy link
Collaborator

@yudong2015: once the present PR merges, I will cherry-pick it on top of release-3.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yudong2015
Copy link
Collaborator Author

/cherrypick release-3.5

@ks-ci-bot
Copy link
Collaborator

@yudong2015: once the present PR merges, I will cherry-pick it on top of release-3.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chilianyi
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 6, 2023
@ks-ci-bot ks-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2023
@chilianyi
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chilianyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot merged commit 783b0f8 into kubesphere:master Nov 6, 2023
7 checks passed
@ks-ci-bot
Copy link
Collaborator

@yudong2015: new pull request created: #1020

In response to this:

/cherrypick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot mentioned this pull request Nov 6, 2023
Merged
@ks-ci-bot
Copy link
Collaborator

@yudong2015: new pull request created: #1021

In response to this:

/cherrypick release-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilianyi chilianyi Awaiting requested review from chilianyi

Assignees

@chilianyi chilianyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@yudong2015 @ks-ci-bot @chilianyi