Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scan branch failed when source type is gitsource #1024

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: scan branch failed when source type is gitsource #1024

merged 1 commit into from
Nov 16, 2023

Conversation

yudong2015
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

None

@ks-ci-bot ks-ci-bot requested a review from a team November 16, 2023 04:11
@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none labels Nov 16, 2023
@yudong2015 yudong2015 requested a review from chilianyi November 16, 2023 04:11
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2023
@chilianyi
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2023
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chilianyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2023
@ks-ci-bot ks-ci-bot merged commit d6a9f6e into kubesphere:patch-kse3.4.1-20231116 Nov 16, 2023
10 checks passed
yudong2015 added a commit that referenced this pull request Nov 20, 2023
@yudong2015
fix: scan branch failed when source type is gitsource (#1024)
6b65524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilianyi chilianyi Awaiting requested review from chilianyi

Assignees

@chilianyi chilianyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yudong2015 @chilianyi @ks-ci-bot