Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagebuild #999

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Imagebuild #999

merged 4 commits into from
Oct 31, 2023

Conversation

Ganbingkun
Copy link
Contributor

@Ganbingkun Ganbingkun commented Sep 29, 2023

What type of PR is this?

/kind feature
/kind design

What this PR does / why we need it:

  • add S2I feature in DevOps module

new Api list:

  • GET /namespaces/{namespace}/imagebuildStrategies // Get all ImageBuildStrategies
  • POST /namespaces/{namespace}/imagebuilds/{imagebuild} // Create an ImageBuild
  • GET /namespaces/{namespace}/imagebuilds // Get all imageBuilds
  • GET /namespaces/{namespace}/imagebuilds/{imagebuild} // Get an ImageBuild
  • DELETE /namespaces/{namespace}/imagebuilds/{imagebuild} // Delete an ImageBuild
  • PUT /namespaces/{namespace}/imagebuilds/{imagebuild} // Update an ImageBuild
  • POST /namespaces/{namespace}/imagebuilds/{imagebuild}/imagebuildRuns // Create an ImageBuildRun
  • GET /namespace/{namespace}/imagebuildRuns // Get all imageBuildRuns
  • GET /namespace/{namespace}/imagebuildRuns/{ImageBuildRun} // Get an imageBuildRun
  • DELETE /namespaces/{namespace}/imagebuildRuns/{ImageBuildRun} // Delete an ImageBuildRun
None

@ks-ci-bot ks-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/design Categorizes issue or PR as related to design. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/release-note-label-needed kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 29, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word v2apha1 in package name should be v2alpha1 ;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Ganbingkun Ganbingkun marked this pull request as ready for review October 20, 2023 15:32
@ks-ci-bot ks-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2023
@yudong2015
Copy link
Collaborator

/lgtm
/approve

@ks-ci-bot ks-ci-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2023
@ks-ci-bot ks-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 31, 2023
@yudong2015
Copy link
Collaborator

/approve

@chilianyi
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chilianyi, yudong2015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chilianyi,yudong2015]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot merged commit 6887f90 into kubesphere:master Oct 31, 2023
7 checks passed
@yudong2015 yudong2015 removed kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants