feat: add capkk CRDs #2409
feat: add capkk CRDs #2409
Conversation
kubesphere-prow
bot
added
release-note
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dbbDylan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubesphere-prow
bot
added
the
size/XL
dbbDylan
force-pushed
the
feature-capkk-crds
branch
from
c2b8613
to
6256e13
Compare
kubesphere-prow
bot
added
size/XXL
|
This PR has multiple commits, and the default merge method is: squash. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
| // +optional | ||
| ConfigRef *corev1.ObjectReference `json:"configRef,omitempty"` | ||
|
|
||
| // ConfigRef is the reference of Pipeline. |
| // ControlPlaneGroupName is the group name of kubernetes control plane nodes. | ||
| // +optional | ||
| ControlPlaneGroupName string `json:"controlPlaneGroupName,omitempty"` | ||
|
|
||
| // WorkerGroupName is the group name of kubernetes worker nodes. | ||
| // +optional | ||
| WorkerGroupName string `json:"workerGroupName,omitempty"` | ||
|
|
||
| // ClusterGroupName is the group name of kubernetes cluster, which contains control plane group and worker group. | ||
| // +optional | ||
| ClusterGroupName string `json:"clusterGroupName,omitempty"` |
There was a problem hiding this comment.
it's batter to set it in annotations
| ConfigRef *corev1.ObjectReference `json:"configRef,omitempty"` | ||
|
|
||
| // ConfigRef is the reference of Pipeline. | ||
| PipelineRef *corev1.ObjectReference `json:"pipelineRef,omitempty"` |
There was a problem hiding this comment.
it batter set it in annotation or label. It is the pipeline that is created through kkcluster, not that kkcluster’s creation depends on the pipeline.
| // can be added as events to the Machine object and/or logged in the | ||
| // controller's output. | ||
| // +optional | ||
| FailureReason *errors.MachineStatusError `json:"failureReason,omitempty"` |
There was a problem hiding this comment.
errors.MachineStatusError or errors.ClusterStatusError
What type of PR is this?
/kind feature
/kind design
What this PR does / why we need it:
Add & Update CRDs which is CAPKK needed.
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: