feat: update kkcore CRDs #2410
feat: update kkcore CRDs #2410
Conversation
kubesphere-prow
bot
added
release-note
kind/feature
|
| // GetHostsFromGroup flatten a specific `Inventory` group with de-duplication. | ||
| func GetHostsFromGroup(inv *Inventory, groupName string, unavailableHosts, unavailableGroups map[string]struct{}) []string { | ||
| var hosts = make([]string, 0) | ||
| if v, ok := inv.Spec.Groups[groupName]; ok { | ||
| unavailableGroups[groupName] = struct{}{} | ||
| for _, cg := range v.Groups { | ||
| if _, exist := unavailableGroups[cg]; !exist { | ||
| unavailableGroups[cg] = struct{}{} | ||
| hosts = append(hosts, GetHostsFromGroup(inv, cg, unavailableHosts, unavailableGroups)...) | ||
| } | ||
| } | ||
|
|
||
| validHosts := make([]string, 0) | ||
| for _, hostName := range v.Hosts { | ||
| if _, ok := inv.Spec.Hosts[hostName]; ok { | ||
| if _, exist := unavailableHosts[hostName]; !exist { | ||
| unavailableHosts[hostName] = struct{}{} | ||
| validHosts = append(validHosts, hostName) | ||
| } | ||
| } | ||
| } | ||
| hosts = append(hosts, validHosts...) | ||
| } | ||
|
|
||
| return hosts | ||
| } |
There was a problem hiding this comment.
move in variable package
There was a problem hiding this comment.
This logic is unique for inventory CRD, so I don't need to move it.
By the way, variable is for playbook, which will store variables when the playbook being executed. But GetHostsFromGroup used for init a valid inventory.
There was a problem hiding this comment.
should not set as a crd.
redscholar
added
lgtm
kubesphere-prow
bot
merged commit 44c9153
into
kubesphere:feature-gitops
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: dbbDylan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit 44c9153.
What type of PR is this?
/kind feature
/kind design
What this PR does / why we need it:
Update kkcore CRDs for CAPKK
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?