-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐾 Update to PF5 - part III #1336
Conversation
4f6d8f8
to
08c64da
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1336 +/- ##
==========================================
- Coverage 36.81% 36.20% -0.61%
==========================================
Files 158 158
Lines 2548 2574 +26
Branches 599 602 +3
==========================================
- Hits 938 932 -6
- Misses 1428 1460 +32
Partials 182 182 ☔ View full report in Codecov by Sentry. |
64c7624
to
08c64da
Compare
cc:// @mnecas hi, we are changing the build from - RUN npm ci && npm run build
+ RUN command -v yarn || npm i -g yarn
+ RUN yarn install --frozen-lockfile --ignore-engines && yarn build |
Signed-off-by: yaacov <[email protected]>
08c64da
to
17efe7f
Compare
Quality Gate passedIssues Measures |
Ref: #1099
Move rest of the code to PF5 elements, use depracted components where needed.
npm
withyarn
- as workaround towebpack
specific version issue ( CON-14300 )yarn
yarn
yarn
react
libraries to "17.0.2" to match console versionchildren
prop toReact.FC
@openshift-console/dynamic-plugin-sdk-webpack
Dropdown
- usingdeprecated
component variantSelect
- usingdeprecated
component variantEmptyState
- using new versionTable
- using new versionCard
- using new versionAlert
- using new versiononToggle
- update usageonChange
- update usage