Support old ubuntu netplan #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
=======================================
Coverage 16.36% 16.36%
=======================================
Files 109 109
Lines 19628 19628
=======================================
Hits 3212 3212
Misses 16135 16135
Partials 281 281
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yaacov <[email protected]>
yaacov
force-pushed
the
support-old-ubuntu-netplan
branch
from
82bc3f6
to
26485bb
Compare
mnecas
reviewed
Sep 12, 2024
mnecas
reviewed
Sep 12, 2024
mnecas
reviewed
Sep 12, 2024
Signed-off-by: yzamir <[email protected]>
Signed-off-by: yzamir <[email protected]>
yaacov
force-pushed
the
support-old-ubuntu-netplan
branch
from
a735889
to
1043a90
Compare
mnecas
reviewed
Sep 12, 2024
Signed-off-by: yzamir <[email protected]>
Signed-off-by: yzamir <[email protected]>
Signed-off-by: yzamir <[email protected]>
|
mnecas
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support old ubuntu netplan
Issue:
Ubuntu 18 uses vertion of netplan that does not support the get subcommand
Fix:
a. add a python script that mimics netplan get command
b. check if current version of netplan support get
c. run the python script in cases netplan does not support get