Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a dockerfile for forklift-api #1042

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

ShakedAviv50313
Copy link
Contributor

No description provided.

@ShakedAviv50313 ShakedAviv50313 changed the title add dockerfile add a dockerfile for forklift-api Sep 18, 2024
@ShakedAviv50313 ShakedAviv50313 marked this pull request as draft September 18, 2024 08:51
@ShakedAviv50313 ShakedAviv50313 marked this pull request as ready for review September 18, 2024 10:35
@fabiand
Copy link
Contributor

fabiand commented Sep 18, 2024

Please use Containerfile

Copy link
Contributor

@fabiand fabiand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the name Containerfile

Copy link

sonarcloud bot commented Sep 18, 2024

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.33%. Comparing base (b7501bc) to head (98f6e97).
Report is 17 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1042      +/-   ##
==========================================
- Coverage   16.35%   16.33%   -0.03%     
==========================================
  Files         110      112       +2     
  Lines       19675    19771      +96     
==========================================
+ Hits         3218     3229      +11     
- Misses      16174    16256      +82     
- Partials      283      286       +3     
Flag Coverage Δ
unittests 16.33% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaacov
Copy link
Member

yaacov commented Sep 19, 2024

@ShakedAviv50313 hi, your commit incorrectly signed off, it should have a "<" and ">" around the email, can you re-sign your commit correctly ?

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Martin Necas <[email protected]>
@mnecas mnecas merged commit e1cbf82 into kubev2v:main Sep 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants