Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt-v2v: Fix bazel build #1046

Merged
merged 1 commit into from
Sep 19, 2024
Merged

virt-v2v: Fix bazel build #1046

merged 1 commit into from
Sep 19, 2024

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Sep 19, 2024

Issue:
When running the make build-virt-v2v-image the bazel is failing due to duplicate and missing dir mentioned in the bazel config.

@mnecas mnecas requested a review from yaacov as a code owner September 19, 2024 13:53
Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.28%. Comparing base (11ebad9) to head (c5713dd).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   16.28%   16.28%           
=======================================
  Files         112      112           
  Lines       19772    19772           
=======================================
  Hits         3220     3220           
  Misses      16268    16268           
  Partials      284      284           
Flag Coverage Δ
unittests 16.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Martin Necas <[email protected]>
Copy link

sonarcloud bot commented Sep 19, 2024

@mnecas mnecas merged commit 30aebf6 into kubev2v:main Sep 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants