ocp: use namespace from Ref when present #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
reviewed
Aug 8, 2023
When looking up VMs in plans we need to use the namespace from the Ref, and not rely on splitting the name Signed-off-by: Benny Zlotnik <[email protected]>
bennyz
force-pushed
the
fix-ambiguous-vm
branch
from
c381004
to
df9305c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ahadas
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking up VMs in plans we need to use the namespace from the Ref, and not rely on splitting the name