Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport ocp boot order #534

Closed
wants to merge 31 commits into from
Closed

backport ocp boot order #534

wants to merge 31 commits into from

Conversation

bennyz
Copy link
Member

@bennyz bennyz commented Aug 14, 2023

  • Skip LUN task progress
  • Fix controller SCC namespace
  • Add missing mounts for virt-v2v container
  • Remove usages of ioutil because it's deprected as of go 1.16
  • Fix LUN warm migration
  • validation: fix openstack shared disk validation
  • plan: check error returned by GetPopulatorTaskName
  • ocp: use source client where needed
  • Exit when virt-v2v cold hit an error
  • Change the storage mapping for OVA
  • OCP: add support for secrets and configmaps
  • fix virt-v2v bracket
  • ocp: use namespace from Ref when present
  • ocp: make export token TTL configurable
  • openstack: use raw format for images
  • backport Fix unit size calculation for memory and disk size #497
  • Fix virt-v2v entrypoint script
  • ocp: fix mapping name check
  • Fix TLS SSL connection to FIPS enabled systems
  • add -layer suffix to ems layer
  • ovirt client: Check if snapshot was created sucesfully
  • ovirt: Do not wait for timeout when snapshot removal fails
  • Refactor snapshot removal
  • Add check for snapshot removal
  • Update the timeout phase with the start time
  • Remove go util wait from bazel
  • Replace MustCode with Code and check if the element exists
  • ignore events from ovirt without 'code'
  • backport Fix disk size alignment when adding FS overhead #512
  • virt-v2v: Build our own fixed appliance on el8
  • ocp: preserve boot order for disks

liranr23 and others added 30 commits July 31, 2023 19:17
@liranr23
Skip LUN task progress
a2f5855 
LUNs disks are a special case. They do not have a task when migrating
and we do not need to update their progress. The disk are pre-made and
just being attached. Therefore, we need to skip them.

Signed-off-by: Liran Rotenberg <[email protected]>
@bkhizgiy @liranr23
Fix controller SCC namespace
a07ae5a 
Signed-off-by: Bella Khizgiyaev <[email protected]>
@ahadas
Add missing mounts for virt-v2v container
406de59 
In c33a65b, we dropped by mistake the libvirt-domain-xml and
vddk-vol-mount mounts from the virt-v2v container when migrating from
vSphere (and kept them only when migrating from OVA provider). This
broke warm migration from vSphere and decrease the speed of
cold-migrations significantly. Thus, adding back the missing mounts.

Signed-off-by: Arik Hadas <[email protected]>
@bennyz @ahadas
Remove usages of ioutil because it's deprected as of go 1.16
4251a2a 
https://pkg.go.dev/io/ioutil

Signed-off-by: Benny Zlotnik <[email protected]>
@liranr23 @ahadas
Fix LUN warm migration
011520b 
When migrating a LUN disk from ovirt source in warm migration we need to
mark the CopyDisk as completed.

Signed-off-by: Liran Rotenberg <[email protected]>
@mmartinv @ahadas
validation: fix openstack shared disk validation
22eae0b 
Fix the shared disk validation when the attachments
array is empty.

Fixes kubev2v#442

Signed-off-by: Miguel Martín <[email protected]>
@mmartinv @ahadas
plan: check error returned by GetPopulatorTaskName
dc846b3 
Signed-off-by: Miguel Martín <[email protected]>
@bennyz @ahadas
ocp: use source client where needed
e6a81db 
Attempt to properly support remote source by using destination and
source clients where appropriate

Signed-off-by: Benny Zlotnik <[email protected]>
@liranr23 @ahadas
Exit when virt-v2v cold hit an error
9be3425 
Since we now support two flows in the virt-v2v image, it doesn't end
with the actual `virt-v2v` command. In that case the pod may end with
success although, it didn't. Now the script will exit with an error on
the first error occurrence.

Signed-off-by: Liran Rotenberg <[email protected]>
@bkhizgiy @ahadas
Change the storage mapping for OVA
322997e 
Signed-off-by: Bella Khizgiyaev <[email protected]>
@bennyz @ahadas
OCP: add support for secrets and configmaps
66fc0b4 
Signed-off-by: Benny Zlotnik <[email protected]>

ocp: make sure the volume is a PVC

Since adding support for OCP to OCP volumes may not only be PVCs so a
nil check has to be made

Signed-off-by: Benny Zlotnik <[email protected]>

ocp: address comments

Signed-off-by: Benny Zlotnik <[email protected]>
@liranr23 @ahadas
fix virt-v2v bracket
0f733b3 
fixing the error in the entrypoint script:
line 5: [: missing `]'

Signed-off-by: Liran Rotenberg <[email protected]>
@bennyz @ahadas
ocp: use namespace from Ref when present
e6cf6c0 
When looking up VMs in plans we need to use the namespace from the Ref,
and not rely on splitting the name

Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz @ahadas
ocp: make export token TTL configurable
d8b762d 
Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz @ahadas
openstack: use raw format for images
b698fd5 
The format has to always be raw for OpenShift Virtualization

Signed-off-by: Benny Zlotnik <[email protected]>
@bkhizgiy @ahadas
backport kubev2v#497
d0f8666 
Signed-off-by: Bella Khizgiyaev <[email protected]>
@liranr23 @ahadas
Fix virt-v2v entrypoint script
da87c4e 
Since we added OVA we had two options to execute the virt-v2v command.
Now the command will be built and will be executed at the end without
conditions regarding the source. This will allow us to know if we had an
error and fail the pod in such case.

Signed-off-by: Liran Rotenberg <[email protected]>
@bennyz @ahadas
ocp: fix mapping name check
7750145 
Consider namespace/name format for source NAD

Signed-off-by: Benny Zlotnik <[email protected]>
@liranr23 @ahadas
Fix TLS SSL connection to FIPS enabled systems
0f0d752 
This patch will bump the ubi9-minimal image and include the fix of the
SSL connection to the cold virt-v2v.

Signed-off-by: Liran Rotenberg <[email protected]>
@bennyz @ahadas
add -layer suffix to ems layer
de76b60 
Signed-off-by: Benny Zlotnik <[email protected]>
@mnecas @ahadas
ovirt client: Check if snapshot was created sucesfully
75496cc 
Signed-off-by: Martin Necas <[email protected]>
@ahadas
ovirt: Do not wait for timeout when snapshot removal fails
dfdc2f8 
When we trigger remove-snapshot and the operation fails, we immediately
break rather than keep waiting until the timeout of waiting for the
result of the operation is reached.

This change also includes refactoring - changing the format of the error
that is generated from ConflictError and simplify the function
Client#CheckSnapshotReady.

Signed-off-by: Arik Hadas <[email protected]>
@mnecas @ahadas
Refactor snapshot removal
1358cce 
Signed-off-by: Martin Necas <[email protected]>
@mnecas @ahadas
Add check for snapshot removal
9aaddfa 
Signed-off-by: Martin Necas <[email protected]>
@mnecas @ahadas
Update the timeout phase with the start time
a3730f7 
Signed-off-by: Martin Necas <[email protected]>
@mnecas @ahadas
Remove go util wait from bazel
247db3f 
Signed-off-by: Martin Necas <[email protected]>
@mnecas @ahadas
Replace MustCode with Code and check if the element exists
80c92a6 
Signed-off-by: Martin Necas <[email protected]>
@ahadas
ignore events from ovirt without 'code'
0bb60b1 
Signed-off-by: Arik Hadas <[email protected]>
@bkhizgiy @ahadas
backport kubev2v#512
890d4a2 
Signed-off-by: Bella Khizgiyaev <[email protected]>
@ahadas
virt-v2v: Build our own fixed appliance on el8
a2ec3ea 
Similar to kubev2v#226 but on el8 (the appliance used with el8 libguestfs does
not support qcow2 images so the image is still compressed within the
container image and extract by the 'entrypoint' script).

Signed-off-by: Arik Hadas <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.5% 6.5% Duplication

@bennyz bennyz closed this Aug 14, 2023
@bennyz bennyz deleted the backport-ocp-boot-order branch August 14, 2023 15:30
@bennyz bennyz restored the backport-ocp-boot-order branch August 14, 2023 15:32
@bennyz bennyz deleted the backport-ocp-boot-order branch August 15, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas Awaiting requested review from ahadas

@eslutsky eslutsky Awaiting requested review from eslutsky

@liranr23 liranr23 Awaiting requested review from liranr23

@mmartinv mmartinv Awaiting requested review from mmartinv

@nyoxi nyoxi Awaiting requested review from nyoxi

@mnecas mnecas Awaiting requested review from mnecas mnecas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bennyz @liranr23 @bkhizgiy @ahadas @mmartinv @mnecas