LUNs disks are a special case. They do not have a task when migrating
and we do not need to update their progress. The disk are pre-made and
just being attached. Therefore, we need to skip them.

Signed-off-by: Liran Rotenberg <[email protected]>

Signed-off-by: Bella Khizgiyaev <[email protected]>

In c33a65b, we dropped by mistake the libvirt-domain-xml and
vddk-vol-mount mounts from the virt-v2v container when migrating from
vSphere (and kept them only when migrating from OVA provider). This
broke warm migration from vSphere and decrease the speed of
cold-migrations significantly. Thus, adding back the missing mounts.

Signed-off-by: Arik Hadas <[email protected]>

https://pkg.go.dev/io/ioutil

Signed-off-by: Benny Zlotnik <[email protected]>

When migrating a LUN disk from ovirt source in warm migration we need to
mark the CopyDisk as completed.

Signed-off-by: Liran Rotenberg <[email protected]>

Fix the shared disk validation when the attachments
array is empty.

Fixes kubev2v#442

Signed-off-by: Miguel Martín <[email protected]>

Signed-off-by: Miguel Martín <[email protected]>

Attempt to properly support remote source by using destination and
source clients where appropriate

Signed-off-by: Benny Zlotnik <[email protected]>

Since we now support two flows in the virt-v2v image, it doesn't end
with the actual `virt-v2v` command. In that case the pod may end with
success although, it didn't. Now the script will exit with an error on
the first error occurrence.

Signed-off-by: Liran Rotenberg <[email protected]>

Signed-off-by: Bella Khizgiyaev <[email protected]>

Signed-off-by: Benny Zlotnik <[email protected]>

ocp: make sure the volume is a PVC

Since adding support for OCP to OCP volumes may not only be PVCs so a
nil check has to be made

Signed-off-by: Benny Zlotnik <[email protected]>

ocp: address comments

Signed-off-by: Benny Zlotnik <[email protected]>

fixing the error in the entrypoint script:
line 5: [: missing `]'

Signed-off-by: Liran Rotenberg <[email protected]>

When looking up VMs in plans we need to use the namespace from the Ref,
and not rely on splitting the name

Signed-off-by: Benny Zlotnik <[email protected]>

Signed-off-by: Benny Zlotnik <[email protected]>

The format has to always be raw for OpenShift Virtualization

Signed-off-by: Benny Zlotnik <[email protected]>

Signed-off-by: Bella Khizgiyaev <[email protected]>

Since we added OVA we had two options to execute the virt-v2v command.
Now the command will be built and will be executed at the end without
conditions regarding the source. This will allow us to know if we had an
error and fail the pod in such case.

Signed-off-by: Liran Rotenberg <[email protected]>

Consider namespace/name format for source NAD

Signed-off-by: Benny Zlotnik <[email protected]>

This patch will bump the ubi9-minimal image and include the fix of the
SSL connection to the cold virt-v2v.

Signed-off-by: Liran Rotenberg <[email protected]>

Signed-off-by: Benny Zlotnik <[email protected]>

Signed-off-by: Martin Necas <[email protected]>

When we trigger remove-snapshot and the operation fails, we immediately
break rather than keep waiting until the timeout of waiting for the
result of the operation is reached.

This change also includes refactoring - changing the format of the error
that is generated from ConflictError and simplify the function
Client#CheckSnapshotReady.

Signed-off-by: Arik Hadas <[email protected]>

Signed-off-by: Martin Necas <[email protected]>

Signed-off-by: Martin Necas <[email protected]>

Signed-off-by: Martin Necas <[email protected]>

Signed-off-by: Martin Necas <[email protected]>

Signed-off-by: Martin Necas <[email protected]>

Signed-off-by: Arik Hadas <[email protected]>

Signed-off-by: Bella Khizgiyaev <[email protected]>

Similar to kubev2v#226 but on el8 (the appliance used with el8 libguestfs does
not support qcow2 images so the image is still compressed within the
container image and extract by the 'entrypoint' script).

Signed-off-by: Arik Hadas <[email protected]>

Signed-off-by: Benny Zlotnik <[email protected]>

DV based disks need to be considered as well

Signed-off-by: Benny Zlotnik <[email protected]>

Signed-off-by: Benny Zlotnik <[email protected]>

Otherwise we end up using the variable which we copy over the same
interface and keep the type

Signed-off-by: Benny Zlotnik <[email protected]>

It seems like dv.PVC is always nil because we don't create a DV from a
PVC, this leads to failing to find the DV whenever the importer pod
fails and it will restart forever instead of 3 times

Signed-off-by: Benny Zlotnik <[email protected]>

rename DataVolume to DataVolumeWrapper

Make it slightly less confusing

Signed-off-by: Benny Zlotnik <[email protected]>

Signed-off-by: Arik Hadas <[email protected]>

Signed-off-by: Arik Hadas <[email protected]>

pkg/controller/plan/adapter/ocp/validator.go:24:23: undefined: logging.LevelLogger

Signed-off-by: Arik Hadas <[email protected]>

Signed-off-by: Benny Zlotnik <[email protected]>