Fix secret admitter to allow OVA provider creation #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bella Khizgiyaev <[email protected]>
Skip connection test when updating secret of OVA provider (the URL doesn't change and credentials are not specified) and reduce congnitive complexity of the validateProviderSecret function. Signed-off-by: Arik Hadas <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
mnecas
reviewed
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new provider being created in the first run we sets the fields of the secrete and in the second iteration the owner reference of the provider, since the second iteration counts as update operation the webhook blocks the provider creation.
This fix checks if the URL field wasn't changed and if not the operation is permitted, this allow to the creation of the provider to pass successfully.
backport of #561